Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize to Jenkins 2.440.3 #93

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

sghill-rewrite
Copy link
Contributor

@sghill-rewrite sghill-rewrite commented Aug 6, 2024

Hi!

This PR aims to move this plugin to the recommended Jenkins baseline version.

If there are additional requirements for accepting PRs - such as additional lag time before adopting a baseline - feel free to reply in the comments.

Testing done

Ran mvn clean verify.

Submitter checklist

Preview Give feedback

Refs: sghill-rewrite/campaigns#4

Closes #81
Closes #89
Closes #91

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin?organizationId=SmVua2lucyBDSQ%3D%3D

@sghill-rewrite sghill-rewrite requested a review from a team as a code owner August 6, 2024 06:25
pom.xml Outdated
@@ -46,9 +46,9 @@
<dependencies>
<dependency>
<groupId>io.jenkins.tools.bom</groupId>
<artifactId>bom-2.361.x</artifactId>
<artifactId>bom-2.440.x</artifactId>
<!-- TODO when updating the bom check for script-security update and remove version override below -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO should be completed as part of the PR that updates the BOM; otherwise, the comment will become stale and confusing.

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit d8b301c into jenkinsci:master Aug 6, 2024
12 of 13 checks passed
@sghill
Copy link

sghill commented Aug 6, 2024

Thank you for the merges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants