Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include removed label in the changelog #25

Merged

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Mar 21, 2022

Include removed label in changelog

Pull requests to Jenkins core that were labeled with removed were not included in the automated weekly changelogs for Jenkins 2.339 and earlier. Let's include them in the changelog.

Original issue was reported at jenkinsci/jenkins#6111 (comment)

jenkins-infra/jenkins.io#4960 (comment) raises the issue in response to the question asking why the JNDI removal was not included in the 2.332.1 upgrade guide.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Pull requests to Jenkins core that were labeled with `remove` were not
included in the automated weekly changelogs for Jenkins 2.339 and earlier.
Let's include them in the changelog.

jenkins-infra/jenkins.io#4960 (comment)
raises the question in response to the question asking why the JNDI
removal was not included in the 2.332.1 upgrade guide.
@timja timja merged commit c13ec50 into jenkinsci:master Mar 21, 2022
@MarkEWaite MarkEWaite deleted the include-removed-label-in-changelog branch November 11, 2022 14:30
@MarkEWaite MarkEWaite added the enhancement New feature or request label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants