Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: pin windowsservercore-ltsc2019 to April 2024 release" #435

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Jul 10, 2024

Reverts #433

This PR removes the Windows Server Core version pinning so we can use its last image version published today as base instead of the one from April 2024.

From microsoft/Windows-Containers#493 (comment):

The updated images released as part of the July 2024 security update today include the fix for this issue.

Confirmed by building this from another host than Windows:

# OK with docker buildx build --platform windows/amd64 -t test .
FROM --platform=windows/amd64 mcr.microsoft.com/windows/servercore:ltsc2019 AS latest
COPY README.md README.md

# OK with docker buildx build --platform windows/amd64 -t test .
FROM --platform=windows/amd64 mcr.microsoft.com/windows/servercore:ltsc2019@sha256:41f42aa4ad39d85e4d30642b8111ca6454ca2275f188f012934b9afbaf63a647 AS latestdigest
COPY README.md README.md

Same as:

Ref:

@lemeurherve lemeurherve requested a review from a team as a code owner July 10, 2024 11:53
@lemeurherve lemeurherve merged commit aec783c into master Jul 10, 2024
11 checks passed
@lemeurherve lemeurherve deleted the revert-433-windows-digest branch July 10, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants