-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(updatecli): update jdk21 manifests #1741
Merged
dduportal
merged 6 commits into
jenkinsci:master
from
lemeurherve:fix-updatecli-manifests
Oct 20, 2023
Merged
chore(updatecli): update jdk21 manifests #1741
dduportal
merged 6 commits into
jenkinsci:master
from
lemeurherve:fix-updatecli-manifests
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16d10dd
to
0e31d54
Compare
dduportal
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The check shows that this PR, once merged, should trigger a new PR to update the preview images to the new 21.0.1+12
EA version:
TARGETS
========
setJDK21PreviewVersionDebian
----------------------------
**Dry Run enabled**
⚠ The line #3, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is changed from "ARG JAVA_VERSION=21+35" to "ARG JAVA_VERSION=21.0.1+12".
⚠ - changed lines [3] of file "21/debian/bookworm/hotspot/preview/Dockerfile"
setJDK21PreviewVersionDockerBake
--------------------------------
**Dry Run enabled**
⚠ - path "variable.JAVA21_PREVIEW_VERSION.default" updated from "21+35" to "21.0.1+12" in file "docker-bake.hcl"
setJDK21PreviewVersionRhel
--------------------------
**Dry Run enabled**
⚠ The line #2, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is changed from "ARG JAVA_VERSION=21+35" to "ARG JAVA_VERSION=21.0.1+12".
⚠ - changed lines [2] of file "21/rhel/ubi9/hotspot/Dockerfile"
setJDK21PreviewVersionDebianSlim
--------------------------------
**Dry Run enabled**
⚠ The line #3, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is changed from "ARG JAVA_VERSION=21+35" to "ARG JAVA_VERSION=21.0.1+12".
⚠ - changed lines [3] of file "21/debian/bookworm-slim/hotspot/preview/Dockerfile"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new updatecli manifest to distinctively track Eclipse Temuring preview images (EA versions), and fixes the existing one to use a "+" in the source version, but target a "_" version as used in the docker-bake file and in the Dockerfiles where official GA temurin images are already used.
Follow-up of #1738
Closes #1739
Testing done
https://github.com/jenkinsci/docker/actions/runs/6587768678/job/17898685768
Logs extract:
Submitter checklist