Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(updatecli): update jdk21 manifests #1741

Merged
merged 6 commits into from
Oct 20, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Oct 19, 2023

This PR introduces a new updatecli manifest to distinctively track Eclipse Temuring preview images (EA versions), and fixes the existing one to use a "+" in the source version, but target a "_" version as used in the docker-bake file and in the Dockerfiles where official GA temurin images are already used.

Follow-up of #1738

Closes #1739

Testing done

https://github.com/jenkinsci/docker/actions/runs/6587768678/job/17898685768

Logs extract:
########################################################
# BUMP JDK21 PREVIEW VERSION (EA) FOR ALL LINUX IMAGES #
########################################################


SOURCES
=======

getLatestJDK21PreviewVersion
----------------------------
Searching for version matching pattern ".*-ea-.*"
✔ Git tag "jdk-21.0.1+12-ea-beta" found matching pattern ".*-ea-.*" of kind "regex"


CONDITIONS:
===========

checkIfReleaseIsAvailable
-------------------------
The shell 🐚 command "/bin/sh /tmp/updatecli/bin/e178f4342f912570a17f53f2079a8f8a53445ca928f785971065f2d450977844.sh" ran successfully with the following output:
----
OK: all JDK URL for version=21.0.1+12-ea-beta are available.
----
✔ shell condition of type "console/output", passing


TARGETS
========

setJDK21PreviewVersionDockerBake
--------------------------------

**Dry Run enabled**

⚠ - path "variable.JAVA21_PREVIEW_VERSION.default" updated from "21+35" to "21.0.1+12" in file "docker-bake.hcl"

setJDK21PreviewVersionRhel
--------------------------

----
✔ shell condition of type "console/output", passing


TARGETS
========

setJDK21VersionDebianSlim
-------------------------

**Dry Run enabled**

✔ The line #2, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is correctly set to "ARG JAVA_VERSION=21_35".
✔ - 

setJDK21VersionDebian
---------------------

**Dry Run enabled**

✔ The line #2, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is correctly set to "ARG JAVA_VERSION=21_35".
✔ - 

setJDK21VersionAlpine
---------------------

**Dry Run enabled**

✔ The line #2, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is correctly set to "ARG JAVA_VERSION=21_35".
✔ - 

setJDK21VersionDockerBake
-------------------------

**Dry Run enabled**

✔ - path "variable.JAVA21_VERSION.default" already set to "21_35", from file "docker-bake.hcl", 

Submitter checklist

Preview Give feedback

@lemeurherve lemeurherve force-pushed the fix-updatecli-manifests branch from 16d10dd to 0e31d54 Compare October 19, 2023 15:56
@lemeurherve lemeurherve marked this pull request as ready for review October 19, 2023 15:56
@lemeurherve lemeurherve requested a review from a team as a code owner October 19, 2023 15:56
@lemeurherve lemeurherve changed the title chore: update jdk21 manifests chore(updatecli): update jdk21 manifests Oct 19, 2023
@lemeurherve lemeurherve marked this pull request as draft October 20, 2023 12:21
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The check shows that this PR, once merged, should trigger a new PR to update the preview images to the new 21.0.1+12 EA version:

TARGETS
========

setJDK21PreviewVersionDebian
----------------------------

**Dry Run enabled**

⚠ The line #3, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is changed from "ARG JAVA_VERSION=21+35" to "ARG JAVA_VERSION=21.0.1+12".
⚠ - changed lines [3] of file "21/debian/bookworm/hotspot/preview/Dockerfile"

setJDK21PreviewVersionDockerBake
--------------------------------

**Dry Run enabled**

⚠ - path "variable.JAVA21_PREVIEW_VERSION.default" updated from "21+35" to "21.0.1+12" in file "docker-bake.hcl"

setJDK21PreviewVersionRhel
--------------------------

**Dry Run enabled**

⚠ The line #2, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is changed from "ARG JAVA_VERSION=21+35" to "ARG JAVA_VERSION=21.0.1+12".
⚠ - changed lines [2] of file "21/rhel/ubi9/hotspot/Dockerfile"

setJDK21PreviewVersionDebianSlim
--------------------------------

**Dry Run enabled**

⚠ The line #3, matched by the keyword "ARG" and the matcher "JAVA_VERSION", is changed from "ARG JAVA_VERSION=21+35" to "ARG JAVA_VERSION=21.0.1+12".
⚠ - changed lines [3] of file "21/debian/bookworm-slim/hotspot/preview/Dockerfile"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants