feat(Linux): switch supported architectures to GA Temurin jdk21 images

[lemeurherve]

This PR switch supported architectures (x86 & arm64) to the GA jdk21 Temurin Linux images.

It keeps jdk21-preview images for unsupported architectures (ppc64le, arm32 and s390x).

It also include a fix for the preview (EA) release download URL.

Follow-up of #518

Depending on #520 decision about archlinux, I could add an archlinux-jdk21 image too. removed from that PR.

Testing done

https://ci.jenkins.io/job/Packaging/job/docker-agent/job/PR-521/32/

Submitter checklist

Beta Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[gounthar]

Maybe we should wait, then, until they become available.

[lemeurherve]

Maybe we should wait, then, until they become available.

I can rework my PR to keep linux-arm32 and linux-ppc64le as jdk21-preview images, WDYT?

EDIT: done.

[timja]

use a multi-arch image to retrieve the jdk please instead of fetching it via wget like we do in all other images

I was looking at an old diff

[timja]

I would probably just wait a couple of days they probably won't take long to produce the other platforms?

[lemeurherve]

Maybe we should wait, then, until they become available.

I can rework my PR to keep linux-arm32 and linux-ppc64le as jdk21-preview images, WDYT?

EDIT: done.

There aren't any binaries for these architectures in recent releases (https://github.com/adoptium/temurin21-binaries/releases).

To keep preview images for these specific architecture without blocking the major ones, I propose to use the (fixed) last release where they're available in

docker-agent/debian/21/Dockerfile

Lines 8 to 19 in f8e2ca6

	RUN set -x; apt-get update \
	&& apt-get install --no-install-recommends -y \
	ca-certificates \
	jq \
	wget \
	&& BUILD_NUMBER=$(echo $JAVA_VERSION | cut -d'+' -f2) \
	&& JAVA_MAJOR_VERSION=$(echo $JAVA_VERSION | cut -d'+' -f1) \
	&& JAVA_VERSION_ENCODED=$(echo "$JAVA_VERSION" | jq "@uri" -jRr) \
	&& CONVERTED_ARCH=$(arch | sed -e 's/x86_64/x64/' -e 's/armv7l/arm/') \
	&& wget --quiet https://github.com/adoptium/temurin"${JAVA_MAJOR_VERSION}"-binaries/releases/download/jdk-"${JAVA_VERSION_ENCODED}"-ea-beta/OpenJDK"${JAVA_MAJOR_VERSION}"U-jdk_"${CONVERTED_ARCH}"_linux_hotspot_ea_"${JAVA_MAJOR_VERSION}"-0-"${BUILD_NUMBER}".tar.gz -O /tmp/jdk.tar.gz \
	&& tar -xzf /tmp/jdk.tar.gz -C /opt/ \
	&& rm -f /tmp/jdk.tar.gz

WDYT?

[lemeurherve]

We can also wait a few days.

[timja]

We can also wait a few days.

I would prefer to just wait a few days they should come out soon

[gounthar]

Thank you.
Here is the current status found here.

⛔ means there is no build planned for that version/platform combination. 🤔
Could we wait for arm32, ppc64le and x64 Windows to go?

There is an explanation in a Temurin repo where they describe the different classes of platforms they support.
I guess s390x is in the last group.

Quote from Temurin, a few minutes ago:

As things stand we are unable to ship a JDK21 build for s390x. We are hopeful that we might be able to ship a build of 21.0.1 with support for s390x

[lemeurherve]

Thank you. Here is the current status found here.

Thanks for the link, quite useful!

Could we wait for arm32, ppc64le [...] to go?

Yes, I'll keep this PR as draft until arm32 & ppc64le images variants are ready.

and x64 Windows

Unrelated to this PR concerning Linux images.

We're already publishing amd64 Windows images (see https://hub.docker.com/r/jenkins/agent/tags?page=1&name=21), which AFAIU are the same architecture.

I can't find the right link at the moment, but there is an explanation somewhere in a Temurin repo where they describe the different classes of platforms they support. I guess s390x is in the last group.

I've removed s390x target architecture for jdk21 as it won't be supported in commit 2d4b319

[lemeurherve]

adoptium/temurin#8 has been closed, and the October release status doesn't look good for the architectures we were waiting for: adoptium/temurin#6

With these new elements at hand, are you OK if I restore a similar workaround as the one deployed in jenkinsci/docker#1738 to keep the preview tags/images like in 2eae836?

[MarkEWaite]

I think that the workaround is a very reasonable compromise.

[dduportal]

+1 with the workaround! Will be double justified as there is a ne EA release for s390x for instance, as pointed by @gounthar : https://github.com/adoptium/temurin21-binaries/releases/tag/jdk-21.0.1%2B12-ea-beta

[gounthar]

Yes, ppc64le, s390x and armv7 are available for the JDK 21.0.1 early access.

[lemeurherve]

I'll prepare the workaround, then as follow-up of this PR I'll prepare another one for updatecli manifests managing both type of versions like jenkinsci/docker#1741

[lemeurherve]

Included back the workaround, and also incorporated the same kind of preview (EA) release download URL fix as jenkinsci/docker#1747

PR ready for review, to be squashed.

[lemeurherve]

I'll prepare the workaround, then as follow-up of this PR I'll prepare another one for updatecli manifests managing both type of versions like jenkinsci/docker#1741

Updatecli manifests update addressed in #536