fix(jdk21-preview): correct release download URL #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemeurherve
force-pushed
the
fix-jdk21-preview-download-url
branch
from
bebd98f
to
2c133e0
Compare
…e list of images to build in the Jenkinsfile
lemeurherve
force-pushed
the
fix-jdk21-preview-download-url
branch
from
c4f7bee
to
67cb965
Compare
lemeurherve
added a commit
to lemeurherve/docker-agent
that referenced
this pull request
Oct 22, 2023
lemeurherve
requested review from
ksalerno99,
saper,
olivergondza and
a team
as code owners
dduportal
reviewed
Oct 22, 2023
| @@ -5,15 +5,21 @@ ARG TARGETPLATFORM | |||
|
|
|||
| SHELL ["/bin/bash", "-o", "pipefail", "-c"] | |||
|
|
|||
| ## Example of preview (EA) jdk21 JAVA_VERSION values: | |||
| # 21+35 (special case) | |||
There was a problem hiding this comment.
not blocking: are you sure it a special case? I believe we must check the temurin official stance on the versioning numbers before doing specific stuff
There was a problem hiding this comment.
I'm sure of the URLs from the temurin binaries repo. I'll search for an official statement about versionning.
There was a problem hiding this comment.
My question is not a blocker: the current code is already good enough for merging!
I was asking because I've seen the pattern like 21+35 (which generates a 21-0_35 or whatever weird behavior adding the minor version 0 in the URL but not the shorthand). on other temurins but I can't remember which one and if it happened multiple times
dduportal
approved these changes
Oct 22, 2023
This was referenced Oct 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the preview (EA) release download links. (cherry-picked #1748)
Follow-up of #1683
Related: #1743
Testing done
https://ci.jenkins.io/job/Packaging/job/docker/job/PR-1747/16/
Submitter checklist