Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(Windows): remove $PushVersion blocks from make.ps1 #1767

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Nov 1, 2023

This PR removes unused block codes related to $PushVersion.

Only existing mention of $PushVersion in this repo:

Similar to:

Note: I intend to refactor make.ps1 to be similar to the build.ps1 of https://github.com/jenkinsci/docker-agent and https://github.com/jenkinsci/docker-inbound-agent, this cleanup will facilitate the comparison between both scripts.

Testing done

Removal of uncalled code, CI should suffice.

Submitter checklist

Preview Give feedback

@lemeurherve lemeurherve marked this pull request as ready for review November 1, 2023 11:45
@lemeurherve lemeurherve requested a review from a team as a code owner November 1, 2023 11:45
@lemeurherve lemeurherve merged commit ab3d4e7 into jenkinsci:master Nov 1, 2023
@lemeurherve lemeurherve deleted the cleanup-windows-script branch November 1, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants