cleanup(Windows): remove unused make.ps1 parameters

[lemeurherve]

This PR removes unused parameters from the make.ps1 Windows image build script:

• $TagPrefix: only occurence in the repository
• $AdditionalArgs: not used
• $Build: not used

Follow-up of:

• cleanup(Windows): remove $PushVersion blocks from make.ps1 #1767

Similar to:

• cleanup(Windows): remove obsolete Build build.ps1 script argument docker-agent#549

Preparing a Windows build refactor, this cleanup will ease the review of the incoming PR.

Testing done

Compared the outputs of pwsh make.ps1 -DryRun, pwsh make.ps1 test -DryRun and pwsh make.ps1 publish -DryRun before and after.

Submitter checklist

Preview Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

[timja]

I'm not sure how much effort I would put into this script?

docker bake support should be coming soon for windows which should hopefully simplify it a lot

[lemeurherve]

I'm not sure how much effort I would put into this script?

I don't have a lot of effort to provide for the refactor like docker-agent and co using a docker-compose file to define the images.These cleanup PRs are mainly to ease the review to come, this one should be the last.

Also, I'm enjoying this process so far 🙂

docker bake support should be coming soon for windows which should hopefully simplify it a lot

+1

With this refactor we'll be able to provide proper tags for Windows image, close a few issues, and get a common build process between official images, which will ease the transition to docker bake when ready.