-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefer -Dchangelist.format=%d.v%s
#19
Conversation
The test is a bit short. I like where this is going based on the description, but it doesn't express enough what the result it accomplishes is. One minor gripe is that for me, |
Basically I need to ensure that there is some prefix you can add to
With the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this!
To test, I am deliberately being a temporary jerk and merging jenkinsci/file-parameters-plugin#27 before jenkinsci/file-parameters-plugin#31, but then relenting and cutting a |
jenkins-infra/github-reusable-workflows#14 may be an issue, unclear. |
So now the 2.263.x UC serves https://github.com/jenkinsci/file-parameters-plugin/releases/tag/99.102.vbc6a133bcbbb while the 2.281 UC serves https://github.com/jenkinsci/file-parameters-plugin/releases/tag/110.vbe06c86f5235, as expected. |
-Dchangelist.format=%d.v%s
this seems incorrect or at least incorrectly applied in plugins where they are just using this and not prefixed version (e.g. mailer) - Maven treats This leads to people using versions like Whilst Jenkins (
prints (in the Jenkins console)
it would seem to me like the changelist format should be |
More likely just seeing #24? |
nope
There is no reason to be using maven 2 so I guess this should be closed. |
Not noise! Maven handling of version numbers is complex and prone to odd behaviors (as we saw in #24) so we need to remain on the lookout for subtle problems affecting JEP-229. |
Judging by jenkinsci/lib-version-number@0071313 this should work better to support backport branches.