Upgrade Jetty 9.2.15 → 9.4.5 #63
Conversation
Signed-off-by: olivier lamy <olamy@apache.org>
|
@jglick @oleg-nenashev please review guys thanks! |
| <jetty.version>9.2.15.v20160210</jetty.version> | ||
| <jetty.version>9.4.5.v20170502</jetty.version> | ||
| <maven-surefire-plugin.version>2.20</maven-surefire-plugin.version> | ||
| <maven-compiler-plugin.version>3.6.1</maven-compiler-plugin.version> |
There was a problem hiding this comment.
Why would you need the explicit versions here?
There was a problem hiding this comment.
Also curious about this. The parent POM defines these versions IIUC.
There was a problem hiding this comment.
well it's really to use more up2date versions :-)
| <jetty.version>9.2.15.v20160210</jetty.version> | ||
| <jetty.version>9.4.5.v20170502</jetty.version> | ||
| <maven-surefire-plugin.version>2.20</maven-surefire-plugin.version> | ||
| <maven-compiler-plugin.version>3.6.1</maven-compiler-plugin.version> |
There was a problem hiding this comment.
Also curious about this. The parent POM defines these versions IIUC.
|
Not sure why CI build is broken; opened #64 to modernize it. |
| realm.update("alice", new Password("alice"), new String[]{"user","female"}); | ||
| realm.update("bob", new Password("bob"), new String[]{"user","male"}); | ||
| realm.update("charlie", new Password("charlie"), new String[]{"user","male"}); | ||
| UserStore userStore = new UserStore(); |
There was a problem hiding this comment.
Forced by Jetty changes as detailed in jetty/jetty.project#1488 (comment). This makes it awkward to switch Jetty versions in a plugin back to 9.2.x, which @vivek says is currently necessary for Wiremock compatibility: you must use
@Rule
public JenkinsRule r = new JenkinsRule() {
@Override
protected LoginService configureUserRealm() {
HashLoginService realm = new HashLoginService();
realm.setName("default");
return realm;
}
};We cannot simply delete the UserStore part from the default implementation; it works for most tests, but not those calling WebClient.login while using LegacySecurityRealm (perhaps indirectly via @PresetData(DataSet.NO_ANONYMOUS_READACCESS)), of which there are a few in core and some plugins. (For example, JnlpAccessWithSecuredHudsonTest, using HudsonTestCase.)
Signed-off-by: olivier lamy olamy@apache.org