Add convenient method to add user to Realm #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new base class UserStore Signed-off-by: olivier lamy <olamy@webtide.com>
…ation to use Signed-off-by: olivier lamy <olamy@webtide.com>
Signed-off-by: olivier lamy <olamy@webtide.com>
janbartel
reviewed
Apr 20, 2017
| _propertyUserStore = null; | ||
| if (_userStore != null) | ||
| _userStore.stop(); | ||
| _userStore = null; |
There was a problem hiding this comment.
I think we need to remember whether the _userStore was explicitly set or we autocreated it: only if we autocreated it should we null it out, otherwise a stop/restart of the context won't work.
janbartel
reviewed
Apr 20, 2017
| propertyUserStore.setHotReload(hotReload); | ||
| propertyUserStore.setConfigPath(_configFile); | ||
| propertyUserStore.start(); | ||
| this._userStore = propertyUserStore; |
There was a problem hiding this comment.
Teeny quibble: you can get rid of the this., as the underscore on the field name is definitive.
There was a problem hiding this comment.
haha grhh usually checkstyle says "this is mandatory" :-)
Signed-off-by: olivier lamy <olamy@webtide.com>
|
81b2a6a forced changes in jenkinsci/jenkins-test-harness#63, which in turn do not work with Jetty 9.2.x; i.e., there is no apparent idiom which works in either version. Was there no way to retain backward compatibility here? Something like @Deprecated
public void update(String userName, Credential credential, String[] roleArray) {
if (_userStore == null) {
_userStore = new UserStore();
}
userStore.addUser(userName, credentials, roleArray);
}
@Deprecated
public void remove(String userName) {
_userStore.removeUser(userName);
}? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1481