Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenient method to add user to Realm #1481

Closed
olamy opened this issue Apr 19, 2017 · 1 comment · Fixed by #1488
Closed

Add convenient method to add user to Realm #1481

olamy opened this issue Apr 19, 2017 · 1 comment · Fixed by #1488
Assignees

Comments

@olamy
Copy link
Member

olamy commented Apr 19, 2017

Implementation notes from @janbartel

  • refactor the PropertyUserStore into UserStore base class that just stores knownUsers and has method to add a user like addUser(String name, Credential credential, String[] roles), and then PropertyUserStore would extend UserStore and feed it users from a property file. That way, either jetty or other projects could create eg an XMLUserStore to read the user info stored in xml files instead.
  • refactor HashLoginService to have a setter to pass in the UserStore to use. For backward compatibilty we could keep the setConfig(String filename) method and autocreate a PropertyUserStore.
@olamy
Copy link
Member Author

olamy commented Apr 19, 2017

Cannot assign to myself but I will work on that :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants