Renamed exclude file and set spotbugs default to medium (#5746)

Co-authored-by: Basil Crow <me@basilcrow.com>
Co-authored-by: Tim Jacomb <timjacomb1+github@gmail.com>

cli/pom.xml

@@ -14,11 +14,6 @@
   <description>Command line interface for Jenkins</description>
   <url>https://github.com/jenkinsci/jenkins</url>
 
-  <properties>
-    <!-- TODO: remove once Medium level is set in the core (JENKINS-36716) -->
-    <findbugs.threshold>Medium</findbugs.threshold>
-  </properties>
-
   <dependencyManagement>
     <dependencies>
       <dependency>

core/pom.xml

@@ -42,6 +42,8 @@ THE SOFTWARE.
     <staplerFork>true</staplerFork>
     <hamcrest.version>2.2</hamcrest.version>
     <xmlunit.version>2.8.2</xmlunit.version>
+    <!-- TODO: JENKINS-36716 - Switch to Medium once SpotBugs is cleaned up, 929 issues on September 26, 2021 -->
+    <spotbugs.threshold>High</spotbugs.threshold>
   </properties>
 
   <dependencyManagement>
@@ -800,7 +802,7 @@ THE SOFTWARE.
       <id>spotbugs</id>
       <properties>
         <!-- In the default profile we always fail the build if there SpotBugs errors -->
-        <findbugs.failOnError>true</findbugs.failOnError>
+        <spotbugs.failOnError>true</spotbugs.failOnError>
       </properties>
     </profile>
     <profile>

pom.xml

@@ -95,10 +95,9 @@ THE SOFTWARE.
     <!-- Minimum Remoting version, which is tested for API compatibility -->
     <remoting.minimum.supported.version>3.14</remoting.minimum.supported.version>
 
-    <!-- TODO: JENKINS-36716 - Switch to Medium once FindBugs is cleaned up, 430 issues on Mar 10, 2018 -->
-    <findbugs.effort>Max</findbugs.effort>
-    <findbugs.threshold>High</findbugs.threshold>
-    <findbugs.excludeFilterFile>${project.basedir}/../src/findbugs/findbugs-excludes.xml</findbugs.excludeFilterFile>
+    <spotbugs.effort>Max</spotbugs.effort>
+    <spotbugs.threshold>Medium</spotbugs.threshold>
+    <spotbugs.excludeFilterFile>${project.basedir}/../src/spotbugs/spotbugs-excludes.xml</spotbugs.excludeFilterFile>
 
     <access-modifier.version>1.25</access-modifier.version>
     <junit.jupiter.version>5.8.1</junit.jupiter.version>