-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed exclude file and set spotbugs default to medium #5746
Conversation
Will it require extending the excludes file before the merge? I'd guess so. There was huge work to cleanup the codebase (thanks to everyone!) but I'd guess there are still some unfixed issues |
I kept Medium for core. We still have a long road to go. But I think like that it is easier to work on the issues. You cannot forget to build the parent when you change the settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I applied some fixups; I hope you don't mind. (If you do, let me know and I'll apply such fixups to a downstream PR in the future.)
This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
Renamed exclude file and set spotbugs default to medium. With this it is easier to switch the core to medium, you can just comment the line in the pom.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entries
section only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).