-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-53823] - Update JTH and commons-io to fix JDK11 compatibility issues #3661
Conversation
Apache Commons IO 2.6 adds a patch for Java 9+ compatibility: "IO-551: Add Automatic-Module-Name MANIFEST entry for Java 9 compatibility.". So I decided to just update the version to resolve upper bounds |
Looks like the HTMLUnit update breaks ZipExtractionInstallerTest, but only on Windows? |
Does not look like platform-specific issue. Maybe Unix tests got interrupted. CC @uhafner who contributed jenkinsci/jenkins-test-harness#103
|
Apparently you need to s/ |
|
I believe this is superceded by #3872 o |
See JENKINS-53823. My plan is to pick up jenkinsci/jenkins-test-harness#110 , but effectively it integrates a lot of other changes. I have not tested HTMLUnit from the last release, but should be ok.
Proposed changelog entries
Submitter checklist
* Use the
Internal:
prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@dwnusbaum @jglick