-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JTH 2.46 #3872
JTH 2.46 #3872
Conversation
@thomasgl-orange the most problematic feature is the space added by default in the path that failed ~48 tests in my previous PR. More information / analysis in #3618 about the correction / troubles encountered. Thank you for coming here to help the bump :) Don't hesitate to ping me if you need help. Note also that there is a change in the way the JavaScript events are triggered that need to be adapted in the tests. |
9537101
to
26e2def
Compare
@Wadeck Thanks for the heads-up, I had completely forgotten to search for other similar PR before starting this one. I see you've dealt with everything related to the htmlunit incompatibilities already, nice! So, I will rewrite this PR based on yours (currently Wadeck/jenkins@297104a4, with JTH 2.42 and all tests being OK), and I will only do the 2.42=>2.46 bump part, fixing the space-in-path mess I have introduced with jenkinsci/jenkins-test-harness#89 :) From what I see of the failed tests so far, it all comes down to I'm push-forcing that now, will see how tests go on this PR (they're still running on my laptop). If this is not acceptable, some alternatives I can think of are:
|
26e2def
to
c7c8993
Compare
@thomasgl-orange when I see the simple commit that solve the issue, I am banging my head on the wall :D Please look at the #3618 about proposal for the next step with this PR. |
@thomasgl-orange Thanks for the pull request! You might need to rebase your patches once #3618 is merged, because the commits were squashed there |
c7c8993
to
34e948f
Compare
…tus which can be removed.
@oleg-nenashev why did you put this on-hold BTW, just so we know if/when we can mark it ready-for-merge and proceed. Thanks |
@thomasgl-orange #3618 has been merged. Could you please rebase your changes so that we have a clean PR? |
Update done (trick is to change target branch to another and back) |
@thomasgl-orange can you now please restore the PR template, check the right checkboxes, and mainly write a changelog? I would like to merge this soon. Thanks! |
@thomasgl-orange also,I suppose we can now consider this non WIP anymore right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's perfect, thank very much Thomas
@batmat: OK, I've edited the PR title and description. And no, it's no more WIP. |
See jenkinsci/jenkins-test-harness#89.
Bump JTH from 2.42 to 2.46, mainly to test Jenkins itself with a space in temp dir path.
Proposed changelog entries
Submitter checklist
Desired reviewers
(several reviewers are already there)