-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused image assets #5777
Conversation
Have you searched plugin sources to make sure there are no users of the small icons proposed for deletion? |
Had a scan through and there's a few that are in use by extremely old plugins (eg ten years old) that haven't had any updates. The only plugin that I found that has recent updates is https://github.com/jenkinsci/release-plugin - it's currently using the atom.gif icon, I'd be happy to make an MR for it to use the new RSS icon currently used by Jenkins |
tbh can't even remember why I touched that plugin, I assume to do with tables to divs but I can't tell now =/. I can merge and release it by the looks of it though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just needs release plugin sorted from what I can see
Just opened a PR for that - jenkinsci/release-plugin#36 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. off topic, I think I should create a PR to remove the experimental header we introduced... 2 years ago 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. off topic, I think I should create a PR to remove the experimental header we introduced... 2 years ago 😅
Yeah probably, not worth keeping that tech debt around since it was never enabled by default This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
Caused JENKINS-69319. |
Proposed changelog entries
mask-icon
, and unnecessary resize handles.What's changed?
mask-icon
- https://www.leereamsnyder.com/blog/favicons-in-2021 - Jenkins now has a lovely colourful icon on Safari ❤️resize
(anything that's not IE11)Screenshots
Old
![image](https://user-images.githubusercontent.com/43062514/135770937-715e144b-5b08-4769-a03b-8389979b496a.png)
New
![image](https://user-images.githubusercontent.com/43062514/135770933-14b749b1-710b-41b9-97c0-e6f05ece46c0.png)
Old
![image](https://user-images.githubusercontent.com/43062514/135770967-bf8a265c-dace-4901-8a73-873f6659f44a.png)
New
![image](https://user-images.githubusercontent.com/43062514/135770981-d0c1ed8e-f162-4cd6-975e-cb9a27692da1.png)
Maintainer checklist
Before the changes are marked as
ready-for-merge
:Proposed changelog entries
are correctupgrade-guide-needed
label is set and there is aProposed upgrade guidelines
section in the PR title. (example)lts-candidate
to be considered (see query).