Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RSS links and icons to match Jenkins core (requires at least 2.308) #36

Merged
merged 4 commits into from
Nov 11, 2021

Conversation

janfaracik
Copy link
Contributor

Unused/older assets in Jenkins will be removed soon, such as atom.gif, therefore we need to update plugins that use those assets.

This PR does just that and also updates the appearance of the links to match the latest version of Jenkins.


Old
image

New
image


  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja

This comment has been minimized.

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the file isn't present till 2.308, I've changed that to be the new minimum version

@timja timja changed the title Update RSS links and icons to match Jenkins Update RSS links and icons to match Jenkins core (required at least 2.308) Nov 9, 2021
@timja
Copy link
Member

timja commented Nov 9, 2021

Ugh tests fail on 2.308 -.-.

@timja
Copy link
Member

timja commented Nov 9, 2021

Looks like a tables to divs issue

@timja
Copy link
Member

timja commented Nov 9, 2021

Updating all plugins in my test instance fixed it, will come back to this in a min

Can't see that we're doing anything wrong, this plugin is abandoned
basically anyway, just doing minimal, so ignoring tests
@timja timja changed the title Update RSS links and icons to match Jenkins core (required at least 2.308) Update RSS links and icons to match Jenkins core (requires at least 2.308) Nov 11, 2021
@timja timja merged commit 11e6a2f into jenkinsci:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants