-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency prettier to v3 #8241
Conversation
Interesting, all the changes seem to be for the default value for It appears this only exists for nicer diffs; which we've basically abandoned for this repo with the Spotless line length/breaking rules. Would it be preferable to change this option? |
13c12f6
to
640f34a
Compare
The new default didn't work out with HTMLUnit before. Hence, the preexisting trailing commas were used sporadically and not covered by rules. |
Where? Seems a bit of an odd one it's very standard to leave trailing comma's in JavaScript. and yes it does give nicer diffs |
=> #8244 |
Was that automated? it looks like https://github.com/jenkinsci/jenkins/pull/8244/files#r1258086417 is just invalid. |
Yeah, IJ ran |
could probably be fixed by slightly adjusting that one line of code I expect. Trailing comma's are much nicer for diffs. |
We've abandoned the idea of nice diffs in favor of Spotless's rigid line break rules. Why does it matter here? |
in the inverse why not have it look better when we can for no cost? There doesn't seem to be a technical reason to change a default value here. |
It's a pretty awkward looking and easy to misread syntax, but TBF that may be my unfamiliarity with it. So minor downside (IMO) to no upside in this repo 🤷 Anyway, nonblocking, just seems wildly inconsistent. |
.prettierrc.json
Outdated
@@ -1,4 +1,5 @@ | |||
{ | |||
"endOfLine": "auto", | |||
"htmlWhitespaceSensitivity": "ignore" | |||
"htmlWhitespaceSensitivity": "ignore", | |||
"trailingComma": "none" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My vote is to stay with the Spotless default rather than introduce our own customizations which then need to be maintained.
Please take a moment and address the merge conflicts of your pull request. Thanks! |
640f34a
to
a6f3c61
Compare
a6f3c61
to
92555d8
Compare
92555d8
to
9285e27
Compare
This PR contains the following updates:
2.8.8
->3.0.0
Release Notes
prettier/prettier (prettier)
v3.0.0
Compare Source
diff
🔗 Release Notes
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.