Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Prettier 3 and add trailing commas #8244

Merged
merged 9 commits into from
Jul 27, 2023
Merged

Update to Prettier 3 and add trailing commas #8244

merged 9 commits into from
Jul 27, 2023

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Jul 10, 2023 •
edited by gitpod-io bot
Loading

Closes #8241

@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Jul 10, 2023
@github-actions
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@NotMyFault NotMyFault mentioned this pull request Jul 10, 2023
Closed
1 task
@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jul 17, 2023
basil
basil reviewed Jul 17, 2023
View reviewed changes
.prettierrc.json Outdated Show resolved Hide resolved
@NotMyFault NotMyFault marked this pull request as ready for review July 18, 2023 08:23
@NotMyFault NotMyFault requested a review from timja July 18, 2023 08:23
@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Jul 18, 2023
@NotMyFault NotMyFault changed the title Add trailing commas Update to Prettier 3 and add trailing commas Jul 18, 2023
@timja
Copy link
Member

timja commented Jul 18, 2023

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jul 18, 2023
@basil basil added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Jul 18, 2023
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Jul 26, 2023
@github-actions
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Jul 26, 2023
@NotMyFault NotMyFault merged commit 74610e0 into jenkinsci:master Jul 27, 2023
15 checks passed
@NotMyFault NotMyFault deleted the full-trailing branch July 27, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basil basil basil left review comments

@timja timja timja approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotMyFault @timja @basil