Remove 'Disable project' button from project view

[janfaracik]

Reverts the revert in #9272

Fix for the workflow-job-plugin test failure here jenkinsci/workflow-job-plugin#437

---

Discussed briefly in the last UX Sig, the 'Disable project' (and 'Add/edit description') button take up a lot of vertical space (roughly 100px) and this forces useful information, such as stage view plugin etc down.

My proposal would be just to remove the 'Disable project' button altogether and instead have users rely on the configure screen to disable projects.

Before

After

Testing done

• Disable button has been removed, still possible to reenable a project from that view however

Proposed changelog entries

• Remove 'Disable project' button from project view.

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[0023-119]

I hope the community will make you bring that button back, because this change is truly horrible and the supposed few pixel gains are negligible on current displays.

[HeikoNardmann]

I hope the community will make you bring that button back, because this change is truly horrible and the supposed few pixel gains are negligible on current displays.

I agree. With the same arguments you could state that "Add description" should vanish as well.

I'd prefer to use a different layout with one column with infos to the left and one with buttons to the right.

Or move "Disable Project" to the left to the other links as well.

[MarkEWaite]

I hope the community will make you bring that button back, because this change is truly horrible and the supposed few pixel gains are negligible on current displays.

My experience is in the other direction. I use a Chromebook laptop and vertical space is quite precious when I'm using that laptop. Removing the wasted vertical space gives me a better chance that the actions I frequently perform will not require that I scroll the screen downward. This change is expected to save me multiple clicks and scrolling to see useful information. In those rare cases where I want to disable a job, I click the app bar and disable it.

[timja]

I click the app bar and disable it.

This moves the disable into the configure job page as its expected to be a rare action and its already available there. Enable has been left on the page as it will be more convenient to quickly enable something and it shouldn't often show.

[0023-119]

Well it's half of 2024, this button has been there for the last 15 years, back in time when 1280x800 laptops were a norm and yet it is now - in the era of 4K screens everywhere - that you found this particular button space-wasting?
Do you guys even have anyone familiar with human-machine interaction stuff in the team?

Make it in line with "add description" - which of the two is definitely more useless and more easily movable to settings - or make it an option for the user to decide.

Removing it completely is the laziest and worst decision possible.

[gwolf2u]

I would rather have it there since it doesn't take that much space anyway
Was easier (in my case) to enable/disable projects on the fly just by clicking the project name not to go to configuration and click save
Was on button click, now is two
Anyway, a redesign of that page would be more useful I'd say

[quarkcz]

Why in the h..l did you remove this button from project screen??!! Why do you think it's such a rare action?

It's so much difficult now to disable project. Please, bring it back or at least make a settings item to turn it on.

Sometimes, I need to temporarily disable >5 projects and then bring them back. You made this much more difficult and time consuming. And for what reson - for 100px???

Make it smaller, move it anywhere on the project screen, but don't force me to go to project settings to disable it.

[uhafner]

@quarkcz @0023-119 @gwolf2u

This PR is merged so it makes no sense to discuss its contents anymore here. If you want to get a disable project toggle button, then please create a followup issue in Jira (and reference this PR). From what I understand the idea is to create an application bar on every Jenkins page where all controls, menus and buttons will appear. Maybe it makes sense to put such a toggle bar into this application bar. Then those controls are visible but take no additional space and help to remove the clutter in Jenkins UI. (The same is true for the edit job description button: it is used by a handful of people only but clutters the UI)

[daniel-beck]

edit job description button: it is used by a handful of people only

citation needed

[jonesbusy]

I've open a PR for the folder plugin to also remove the disable button for multibranch: jenkinsci/cloudbees-folder-plugin#419

It looks strange to me to have those button for multibranch but not other branch types. I personally never used such button and would like to get rid of them everywhere.

Not sure if there should be a way to restore them like https://plugins.jenkins.io/disable-job-button/

[daniel-beck]

I personally never

It's the only interactive UI element I use regularly on trusted.ci (besides "Build Now" I guess). Now what?

[jonesbusy]

Not sure to get it, but I'm raising the point that removing the Disable button for all jobs exception multibranch is an inconsistence for me

[daniel-beck]

@jonesbusy I do not disagree, it should be consistent. So if it's gone from core, it should be gone from plugins.

I point out that we don't have great ways to determine what features/UI elements are used and what aren't from the user base, and unless we define and want to encourage best practices, it's all just guesses, and we should be careful when extrapolating from oneself.

[mazer1310]

Count me as one of the people impacted by this. I frequently have to disable dozens of jobs at the same time (for instance, when working on bulk configuration changes, bulk runner node changes) and having this button on the main job page is critical for being able to do so efficiently.

Fortunately, I found this Jenkins community discussion: https://community.jenkins.io/t/lost-the-disable-button/18134
which includes a link to a plugin that restores the button: https://plugins.jenkins.io/disable-job-button/
and that has allowed me to get things back as I need them.

[caichao1103]

Can we bring the button back. We have Ops role and Admin role. Ops have the rights to run/enable/disable jobs but have not the right to configure the job.

[jonesbusy]

FYI : https://plugins.jenkins.io/disable-job-button/