Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine button appearances in sidebars, menus, pages and breadcrumbs #9367

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jun 9, 2024

Small one to refine the appearance of buttons in sidebars, menus, pages and breadcrumbs. In a similar fashion to #9366 font sizes and spacing has been adjusted for consistency and to also align with whole pixels.

Before
image

After
image

Sidebars are now slightly more compact and less bold, allowing for more items on screen at once

Before
image

After
image

Buttons are slightly larger as a result of the increase in font size, bringing consistency with other font sizes

Before
image

After
image

Dropdowns are slightly less bold

Before
image

After
image

Breadcrumbs have had their font size adjusted slightly for consistency and to align with whole pixels

Testing done

  • Using the Design Library everything looks as expected

Proposed changelog entries

  • Refine button appearances in sidebars, menus, pages and breadcrumbs.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

@timja timja added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Jun 9, 2024
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timja timja requested a review from a team June 9, 2024 09:43
@timja
Copy link
Member

timja commented Jun 10, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 10, 2024
@MarkEWaite MarkEWaite merged commit 73de53a into jenkinsci:master Jun 11, 2024
17 checks passed
@janfaracik janfaracik deleted the update-button-appearance branch June 11, 2024 06:45
@0023-119
Copy link

So let's rephrase those changes: you basically made everything slightly bigger for no apparent reason, and yet you decided to remove the Disable job button in #9287 because it used few pixels of space?
This is ridiculous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants