JenkinsJobManagement: Include exception in failure logs #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the process of adding new features by including the full stack trace in the logs. This helps make clear what has gone wrong with the generated syntax.
| @@ -127,7 +127,7 @@ private boolean updateExistingJob(AbstractProject<?, ?> project, String config) | |||
| project.updateByXml(streamSource); | |||
| created = true; | |||
| } catch (IOException ioex) { | |||
| LOGGER.log(Level.WARNING, String.format("Error writing updated project to file.")); | |||
| LOGGER.log(Level.WARNING, String.format("Error writing updated project to file."), ioex); | |||
There was a problem hiding this comment.
We had that in there before, but thought end users wouldn't want it. But I'm guessing that we're nascent enough that should be in there to help people develop it.
There was a problem hiding this comment.
While it's true that such reports are really verbose, as a developer I always find it helpful to know what actually went wrong. :-) Users will appreciate being able to submit more useful bug reports perhaps.
quidryan
added a commit
that referenced
this pull request
Sep 26, 2012
JenkinsJobManagement: Include exception in failure logs
sanicheev
pushed a commit
to sanicheev/job-dsl-plugin
that referenced
this pull request
Oct 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the process of adding new features by including
the full stack trace in the logs. This helps make clear
what has gone wrong with the generated syntax.