Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JenkinsJobManagement: Include exception in failure logs #2

Merged
merged 1 commit into from
Sep 26, 2012
+2 −2
Merged

JenkinsJobManagement: Include exception in failure logs #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/groovy/javaposse/jobdsl/plugin/JenkinsJobManagement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ private boolean updateExistingJob(AbstractProject<?, ?> project, String config)
project.updateByXml(streamSource);
created = true;
} catch (IOException ioex) {
LOGGER.log(Level.WARNING, String.format("Error writing updated project to file."));
LOGGER.log(Level.WARNING, String.format("Error writing updated project to file."), ioex);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had that in there before, but thought end users wouldn't want it. But I'm guessing that we're nascent enough that should be in there to help people develop it.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's true that such reports are really verbose, as a developer I always find it helpful to know what actually went wrong. :-) Users will appreciate being able to submit more useful bug reports perhaps.

created = false;
}
return created;
Expand All @@ -146,7 +146,7 @@ private boolean createNewJob(String jobName, String config) {
LOGGER.log(Level.WARNING, "Unsupported encoding used in config. Should be UTF-8.");
created = false;
} catch (IOException ioex) {
LOGGER.log(Level.WARNING, String.format("Error writing config for new job %s.", jobName));
LOGGER.log(Level.WARNING, String.format("Error writing config for new job %s.", jobName), ioex);
created = false;
}
return created;
Expand Down