Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-73788] Reduce metrics bloat relating to provisioning requests #1604

Merged

Conversation

PayBas
Copy link
Contributor

@PayBas PayBas commented Sep 17, 2024

See https://issues.jenkins.io/browse/JENKINS-73788 for details

Testing done

Compiled+unittested the plugin.
Installed to local Jenkins without issues.
Small scale test indicates that the troublesome metrics are no longer collected. I can roll this out to a larger Jenkins instance for more thorough (live) testing, but that will have to wait for our maintenance window.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@PayBas PayBas requested a review from a team as a code owner September 17, 2024 12:42
@Vlatombe
Copy link
Member

Follows up #872

Copy link
Member

@Vlatombe Vlatombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I don't have on-hands experience with using these metrics in real production environments, but given its location, I can understand it can be problematic, so I'm good with removing it.

@Vlatombe Vlatombe added the bug Bug Fixes label Sep 17, 2024
@Vlatombe Vlatombe changed the title JENKINS-73788 Reduce metrics bloat relating to provision.request [JENKINS-73788] Reduce metrics bloat relating to provisioning requests Sep 17, 2024
@Vlatombe Vlatombe merged commit 1719f9d into jenkinsci:master Sep 17, 2024
8 checks passed
@Vlatombe
Copy link
Member

Thank you for your contribution!

@PayBas PayBas deleted the bugfix/JENKINS-73788-reduce-metrics-bloat branch September 19, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants