Add dropwizard metrics to track status of pods #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vlatombe
requested changes
Oct 29, 2020
src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud.java
Outdated
Show resolved
Hide resolved
src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud.java
Outdated
Show resolved
Hide resolved
src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesLauncher.java
Outdated
Show resolved
Hide resolved
Vlatombe
reviewed
Nov 9, 2020
| @@ -679,7 +691,6 @@ public PodTemplate getUnwrappedTemplate(PodTemplate podTemplate) { | |||
| } | |||
|
|
|||
| /** | |||
| * Add a new template to the cloud | |||
Vlatombe
approved these changes
Nov 9, 2020
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add some basic dropwizard metrics to track status of provisioned pods.
I migrated Jenkins instances from Mesos to Kubernetes recently and noticed that the kube plugin doesn't provide metrics related to builder nodes provisioning like the mesos plugin does.
These metrics become useful at scale when the number of Jenkins instance is quite big and they help to spot issues with Jenkins -> cloud provider as early as possible.
I took the same approach as the mesos plugin and use dropwizard metrics (and the metrics plugin), however, I personally not a big fan of them as they don't have labels like the prometheus metrics client. Micrometer can be an alternative, it's like slf4j for logs. Any help with the metrics and what's the current stance in the jenkins world on them would be great.