Add Pod log for kubernetes agent #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlossg Could you please help to review this PR? |
|
@jenkinsci/cloud-native-sig Anyone could help me to review this? Thanks. |
oleg-nenashev
requested changes
Aug 26, 2018
src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesComputer.java
Outdated
Show resolved
Hide resolved
src/main/resources/org/csanchez/jenkins/plugins/kubernetes/KubernetesComputer/sidepanel2.jelly
Show resolved
Hide resolved
src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesComputer.java
Outdated
Show resolved
Hide resolved
LinuxSuRen
force-pushed
the
fea/pod-log
branch
from
ec823c2
to
96a848e
Compare
|
Does it have any other issues? |
carlossg
reviewed
Sep 19, 2018
src/main/resources/org/csanchez/jenkins/plugins/kubernetes/KubernetesComputer/sidepanel2.jelly
Outdated
Show resolved
Hide resolved
carlossg
approved these changes
Sep 19, 2018
|
ping @oleg-nenashev |
1 similar comment
|
ping @oleg-nenashev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know whether there will have a kubernetes environment, so I don't offer a test case.