Fix incorrect permission checks in KubernetesComputer views #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richbg
approved these changes
Sep 1, 2020
jglick
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Theoretically these could be gated by Computer.CONFIGURE, in case some non-admin user has permission to manage nodes, though practically that would not be useful for Cloud-provisioned nodes since typical AuthorizationStrategys would not let you set up distinct permissions on those anyway. So I think this is fine. These are basically all r/o views anyway right?
FTR, Configure is explicitly denied on these ephemeral nodes to prevent access to the configuration page. |
Yes, I was reluctant to #657 because of the possible secret exposure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#367 added views for
KubernetesComputer. The backends methods need administer role however the views are not protected. They don't display stacktraces since #430 however, the links shouldn't even be there.Noting #657 is proposing to require
EXTENDED_READonly. Will likely be affected by this PR.