Modernize to Jenkins 2.440.3

[sghill-rewrite]

Hi!

This PR aims to move this plugin to the recommended Jenkins baseline version.

If there are additional requirements for accepting PRs - such as additional lag time before adopting a baseline - feel free to reply in the comments.

Testing done

Ran mvn clean verify.

I found a new SpotBugs rule started failing, so I added a SuppressFBWarnings annotation to retain backwards compatibility. It would also be possible to make the public fields private, but I opted to suppress to avoid breaking changes.

Submitter checklist

Preview Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

Refs: sghill-rewrite/campaigns#4

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin?organizationId=SmVua2lucyBDSQ%3D%3D

[hypery2k]

thanks for the contribution. Did the spotbugs need special permissions?

The action is failing: https://github.com/jenkinsci/log-parser-plugin/actions/runs/10269784917/job/28416024894?pr=114#step:6:14

[sghill]

@hypery2k I don't think so, I added this because mvn verify failed on the spotbugs:check task the Jenkins tooling includes:

[INFO] --- spotbugs:4.8.3.1:check (spotbugs) @ log-parser ---
[INFO] BugInstance size is 3
[INFO] Error size is 0
[INFO] Total bugs: 3
[ERROR] Medium: Primitive field hudson.plugins.logparser.LogParserPublisher.failBuildOnError is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.logparser.LogParserPublisher] At LogParserPublisher.java:[line 62] PA_PUBLIC_PRIMITIVE_ATTRIBUTE
[ERROR] Medium: Primitive field hudson.plugins.logparser.LogParserPublisher.showGraphs is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.logparser.LogParserPublisher] At LogParserPublisher.java:[line 63] PA_PUBLIC_PRIMITIVE_ATTRIBUTE
[ERROR] Medium: Primitive field hudson.plugins.logparser.LogParserPublisher.unstableOnWarning is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.logparser.LogParserPublisher] At LogParserPublisher.java:[line 61] PA_PUBLIC_PRIMITIVE_ATTRIBUTE

It looks like that's a custom action that was added. Is it needed if spotbugs is already wired into the lifecycle?