use new dialog to prompt for user/group #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaces the browser built-in prompt and alert calls with the dialogs for better theming.
|
@mawinter69 How eager are you to see a release with this change? |
|
As this is just nice to have it is not urgent from my point of view. |
1 task
|
Either this or #152 causes jenkinsci/acceptance-test-harness#1803. |
|
On further inspection, jenkinsci/acceptance-test-harness#1803 is caused by this PR, not #152. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces the browser built-in prompt and alert calls with the dialogs for better theming.
Testing done
Manual testing
Submitter checklist