Modernize to Jenkins 2.440.3

[sghill-rewrite]

Hi!

This PR aims to move this plugin to the recommended Jenkins baseline version.

If there are additional requirements for accepting PRs - such as additional lag time before adopting a baseline - feel free to reply in the comments.

Testing done

Ran mvn clean verify.

Submitter checklist

Preview Give feedback

1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
2. Ensure that the pull request title represents the desired changelog entry
3. Please describe what you did
4. Link to relevant issues in GitHub or Jira
5. Link to relevant pull requests, esp. upstream and downstream changes
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

Refs: sghill-rewrite/campaigns#4

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.jenkins.ModernizePlugin?organizationId=SmVua2lucyBDSQ%3D%3D

[daniel-beck]

Thanks for your PR. 2.426.x is still supported by update sites (as is 2.414.x) and I see no reason to update to a later version at this time.

[sghill]

Thanks for the note. Would you consider update site support the main factor in your decision to upgrade, or are there others?

[daniel-beck]

Would you consider update site support the main factor in your decision to upgrade

It's one of the reasons. I'm co-author of most of the criteria listed in the docs, and support most of them. I just see the recommendation more as a fallback, rather than "if you end up older than this, you should update". This is why the criteria includes the update site rule, even though it will always be lower than the recommendations -- once you're that old, things start getting awkward (testing via mvn hpi:run will be impacted, and you're developing for users who'll have trouble installing your work).

Looking over the list:

• Keeping the Jenkins version your plugin builds against low: Applies to the current version.
• Building against recent Jenkins versions: Improved here, but without new feature use or breaking ATH/PCT/BOM builds, doesn't seem that relevant. Note that I readily updated to the current baseline to get nicer JS popups from use new dialog to prompt for user/group #159.
• Do not use versions no longer supported by the update center: The current version is compliant.
• Prefer an LTS version over weekly versions: The current version is compliant.
• Prefer releases that result in few or no implied plugin dependencies: The current version is compliant.