[JEP-200] POM updates

[jglick]

Routine POM cleanups, permitting tests to be run against newer Jenkins versions than the declared baseline.

Attempting to test against jenkinsci/jenkins#3120, since code inspection suggests that the RemoteScanResult.scan field will fail to be deserialized from agents in Jenkins 2.102+. Unfortunately you appear to have no functional tests whatsoever which would build on agents; when I tried

diff --git a/src/test/java/org/sonatype/nexus/ci/iq/IqPolicyEvaluatorIntegrationTest.groovy b/src/test/java/org/sonatype/nexus/ci/iq/IqPolicyEvaluatorIntegrationTest.groovy
index c3be5a2..767d944 100644
--- a/src/test/java/org/sonatype/nexus/ci/iq/IqPolicyEvaluatorIntegrationTest.groovy
+++ b/src/test/java/org/sonatype/nexus/ci/iq/IqPolicyEvaluatorIntegrationTest.groovy
@@ -108,6 +108,7 @@ class IqPolicyEvaluatorIntegrationTest
   def 'Freestyle build (happy path)'() {
     given: 'a jenkins project'
       FreeStyleProject project = jenkins.createFreeStyleProject()
+      project.assignedNode = jenkins.createSlave()
       project.buildersList.add(new IqPolicyEvaluatorBuildStep('stage', 'app', [], false, 'cred-id'))
       configureJenkins()

it did not work, I suppose because you are using Java mocks rather than an actual mock (HTTP?) service, and mocks do not transfer across JVM boundaries.

I also have no idea how to test this plugin manually, and no inclination to try. The regression, if real, could most likely be corrected by creating a src/main/resources/META-INF/hudson.remoting.ClassFilter containing

com.sonatype.insight.scan.model.Scan
com.sonatype.insight.scan.model.Application
# …whatever the transitive serial closure of Scan might be

or by simply making the Remoting channel transfer only simpler datatypes, such as String, rather than relying on serialization of external libraries.

@reviewbybees

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

[oleg-nenashev]

So good so far. POM definitely needs more cleanup to make the build green eventually

[oleg-nenashev]

Not required though should not harm as well

[oleg-nenashev]

Needs to be removed for Plugin POM 3.2 IIRC

[whyjustin]

Thanks for the alert on JENKINS-47736 and JEP 200. Will look into the feasibility of using simple data types or instead utilize src/main/resources/META-INF/hudson.remoting.ClassFilter. This is a fairly large change (2.22 -> 3.2) we'll do a quick review before merging.

[oleg-nenashev]

I have created https://issues.jenkins-ci.org/browse/JENKINS-48940

[whyjustin]

Took @jglick changes, added whitelist and supporting tests for remote slaves in #17. Thanks again. Closing in favor of #17.