Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

JENKINS-48940 INT-418 Add whitelist for serialized classes. #17

Merged
merged 2 commits into from
Jan 17, 2018

Conversation

whyjustin
Copy link
Member

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming that the deserialization of classes is safe. CC @jglick

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Copy link

@fernau fernau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@whyjustin whyjustin merged commit ccc6e8c into master Jan 17, 2018
@whyjustin whyjustin deleted the JENKINS-47736_Switch_XStream_Blacklist_To_Whitelist branch January 17, 2018 02:51
@oleg-nenashev
Copy link
Member

@whyjustin do you plan to release it soon? Thanks!

@whyjustin
Copy link
Member Author

@whyjustin do you plan to release it soon? Thanks!

@oleg-nenashev I can release later today. IIUC the major version bump in the parent pom is only due to removing support for Jenkins 1.x? Trying to determine if that affects our versioning.

@oleg-nenashev
Copy link
Member

@whyjustin There is a version bump in the Parent POM file. It has been done due to some major changes inside like changing the default Java/Jenkins version. But your POM explicitly sets Jenkins version to 2.7 (see the jenkins.version property), so nothing should change in your case

Copy link

@bigspotteddog bigspotteddog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

bigspotteddog pushed a commit that referenced this pull request Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants