Merge pull request #198 from jglick/redirectTestOutputToFile

Do not force maven.test.redirectTestOutputToFile=false on test runs
jenkinsci · Oct 2, 2019 · 4a9dad7 · 4a9dad7
2 parents ba980f3 + c3bcaa8
commit 4a9dad7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java b/plugins-compat-tester/src/main/java/org/jenkins/tools/test/PluginCompatTester.java
@@ -503,7 +503,6 @@ private TestExecutionResult testPluginAgainst(MavenCoordinates coreCoordinates,
             }
 
             List<String> args = new ArrayList<>();
-            args.add("--define=maven.test.redirectTestOutputToFile=false");
             args.add("--define=forkCount=1");
             args.add("hpi:resolve-test-dependencies");
             args.add("hpi:test-hpl");
@@ -519,9 +518,10 @@ private TestExecutionResult testPluginAgainst(MavenCoordinates coreCoordinates,
             forExecutionHooks.put("config", config);
             forExecutionHooks.put("pluginDir", pluginCheckoutDir);
             pcth.runBeforeExecution(forExecutionHooks);
+            args = (List<String>)forExecutionHooks.get("args");
 
             // Execute with tests
-            runner.run(mconfig, pluginCheckoutDir, buildLogFile, ((List<String>)forExecutionHooks.get("args")).toArray(new String[args.size()]));
+            runner.run(mconfig, pluginCheckoutDir, buildLogFile, args.toArray(new String[args.size()]));
 
             return new TestExecutionResult(((PomData)forExecutionHooks.get("pomData")).getWarningMessages());
         }catch(PomExecutionException e){