-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-60474] streamline the pom and support the jenkins-bom #269
Merged
Merged
Changes from 35 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
e5b32d4
remove findbugs legacy and skip profile
jtnord a0be78d
always run integration tests for this pom
jtnord 9ca3bdb
remove old concurrency override
jtnord fdc501e
junit-dep is not provided by jenkins-test-harness anymore
jtnord 0b4fdac
add a quick-build profile that skips enforcer,tests,spotbugs and anim…
jtnord 09cde37
findbugs is dead
jtnord 38a5f3c
executable-war is not needed, just use the war
jtnord 320374a
[JENKINS-60474] unconditionally enable the jenkins-bom for library de…
jtnord 4569982
there is no excuse for allowing evry single plugin to have falky tests.
jtnord 50bfd73
remove an unneeded property (plugin.minimumJavaVersion)
jtnord 11afd7d
inline trimStackTrace and add failsafe to the build.
jtnord f21e6cb
whitespace changes to make following easier
jtnord 1115636
remove support for jgit provider
jtnord 9afd792
leave a better reference for people about timestamped snapshots
jtnord 5efade2
InjectedTest is a generated test source and these are already excluded.
jtnord 755371c
enforce no snapshots for releases.
jtnord 97cabd7
the snapshot rule needs special handling so we can run an ITs against a
jtnord 367d4e9
remove old animal sniffer versions we only need to support 1.8 or newer
jtnord 48070e4
you can not activate profiles based on properties defined in a project
jtnord a498d8a
tidy up some comments
jtnord b28f137
define spotbugs plugin version in pluginManagement
jtnord 2e284e7
make this a beta version as suggested by @oleg-nenashev
jtnord 793f39f
no need to enable the profile - its always active now
jtnord 3e62514
skip the invoker plugin in the quick-build profile
jtnord 586d740
Merge branch 'master' into JENKINS-60474
jtnord 7dc1c18
turns out the executable-war is magic.
jtnord bb4f3e2
Merge remote-tracking branch 'origin/master' into JENKINS-60474
jtnord 642ef9d
Fix up building now that we always run the integration tests
jtnord d246f1c
there is no information and that URL is garbage so just remove it
jtnord 59018c0
just activate the benchmark profile with a standard profile activation
jtnord bf90d59
Update README
jtnord 15e346f
change version to 4.0-beta-1-SNAPSHOT
jtnord 19dab6c
benchmark activation is via profile
jtnord 8c9203c
make it easier to consume a plugin-pom PR in a incrementals PR
jtnord b9b10c3
Merge branch 'master' into JENKINS-60474
oleg-nenashev c13f626
Restore the release drafter link
oleg-nenashev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ node('maven') { | |
// TODO Azure mirror | ||
ansiColor('xterm') { | ||
withEnv(['MAVEN_OPTS=-Djansi.force=true']) { | ||
sh 'mvn -B -Dstyle.color=always -ntp -Prun-plugin-pom-its clean verify' | ||
sh 'mvn -B -Dstyle.color=always -ntp clean verify' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is no longer a profile it is in the main definition |
||
} | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/jenkinsci/plugin-pom/pull/204/files#r288900798 was not followed up and it is confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is just broken. The correct one is https://github.com/jenkinsci/.github/blob/master/.github/release-drafter.adoc