Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old requireUpperBoundDeps exclusions #457

Closed
wants to merge 1 commit into from

Conversation

jglick
Copy link
Member

@jglick jglick commented Nov 16, 2021

Noticed looking at #456. If I read #269 right, these have been unnecessary since 4.0.

@jglick jglick requested review from basil and jtnord November 16, 2021 21:04
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried this with some real-world plugins? With this PR I get build errors in most plugins I maintain, typically for JNA and Guava, in all but the very latest cores. Personally I am -0; I think this PR is a bit too aggressive but won't stand in the way. I would be in favor of this PR if the JNA and Guava exclusions were retained. I think we need to wait until more plugins adopt recent cores before it will be practical to start enforcing correctness of JNA and Guava dependencies.

@jglick jglick marked this pull request as draft November 17, 2021 13:55
@jglick
Copy link
Member Author

jglick commented Nov 17, 2021

Have you tried this with some real-world plugins?

Nope, just the ITs.

in all but the very latest cores

So the existing comments are wrong?

@basil
Copy link
Member

basil commented Nov 30, 2021

So the existing comments are wrong?

I cannot understand the existing comments, so I cannot judge them.

@jglick
Copy link
Member Author

jglick commented Dec 17, 2021

#477 is actually doing the opposite.

@jglick jglick closed this Dec 17, 2021
@jglick jglick deleted the requireUpperBoundDeps branch December 17, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants