Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore jsr305 warnings #202

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Ignore jsr305 warnings #202

merged 1 commit into from
Nov 30, 2021

Conversation

basil
Copy link
Member

@basil basil commented Nov 30, 2021

plugin-pom already has this exclusion, and without this I get annoying errors in some cases like

Require upper bound dependencies error for com.google.code.findbugs:jsr305:3.0.1 [provided] paths to dependency are:
+-org.jenkins-ci.main:cli:2.324-SNAPSHOT
  +-com.github.spotbugs:spotbugs-annotations:4.5.0 [provided]
    +-com.google.code.findbugs:jsr305:3.0.1 [provided] (managed) <-- com.google.code.findbugs:jsr305:3.0.2 [provided]

CC @jglick

@basil basil added the internal label Nov 30, 2021
jglick
jglick approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure? We do not want to use this library anyway (deprecated).

@jglick jglick added bugfix and removed internal labels Nov 30, 2021
@jglick jglick merged commit 20f15ab into jenkinsci:master Nov 30, 2021
@basil basil deleted the jsr305 branch November 30, 2021 17:47
@basil
Copy link
Member Author

basil commented Nov 30, 2021

Thanks. Any chance you could release an addendum to 1.68 with this fix? Would help me with some upcoming pom.xml cleanups in core (not yet posted) where I am tripping on this.

@jglick
Copy link
Member

jglick commented Nov 30, 2021

I will cut a new release.

BTW jenkinsci/plugin-pom#457 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basil @jglick