Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SpotBugs from 4.2.3 to 4.7.2.1 #629

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

basil
Copy link
Member

@basil basil commented Nov 2, 2022

The main reason we had suppressed this upgrade in spotbugs/spotbugs#1601 (comment) was because of some newly-added noisy bug patterns. Those bug patterns don't appear to have been fixed in the intervening year, so suppress them globally to allow us to complete the upgrade. To test this change I ran SpotBugs on workflow-cps and confirmed there were tons of new violations until I added <spotbugs.omitVisitors>FindReturnRef</spotbugs.omitVisitors> after which there were no new violations.

@basil basil added the dependencies Pull requests that update a dependency file label Nov 2, 2022
@basil basil requested a review from jglick November 2, 2022 22:15
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, had forgotten this was still outstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants