Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit FindReturnRef SpotBugs visitor #335

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

basil
Copy link
Member

@basil basil commented Nov 2, 2022

Like jenkinsci/plugin-pom#629 but for jenkinsci/pom. To test this I verified that mvn clean verify -DskipTests passed on core with

diff --git a/pom.xml b/pom.xml
index 4595a42314..3db08a51ee 100644
--- a/pom.xml
+++ b/pom.xml
@@ -28,7 +28,7 @@ THE SOFTWARE.
   <parent>
     <groupId>org.jenkins-ci</groupId>
     <artifactId>jenkins</artifactId>
-    <version>1.90</version>
+    <version>1.91-SNAPSHOT</version>
     <relativePath />
   </parent>
 
diff --git a/src/spotbugs/spotbugs-excludes.xml b/src/spotbugs/spotbugs-excludes.xml
index 0971834a23..d3fe630c37 100644
--- a/src/spotbugs/spotbugs-excludes.xml
+++ b/src/spotbugs/spotbugs-excludes.xml
@@ -88,236 +88,6 @@
           <Class name="hudson.tasks.Fingerprinter$FingerprintAction"/>
         </Or>
       </And>
-      <And>
-        <Bug pattern="EI_EXPOSE_REP"/>
-        <Or>
-          <Class name="hudson.cli.FullDuplexHttpStream"/>
-          <Class name="hudson.init.TaskMethodFinder$TaskImpl"/>
-          <Class name="hudson.Launcher$DecoratedLauncher"/>
-          <Class name="hudson.Launcher$ProcStarter"/>
-          <Class name="hudson.logging.LogRecorder"/>
-          <Class name="hudson.logging.LogRecorder$Target"/>
-          <Class name="hudson.logging.LogRecorderManager"/>
-          <Class name="hudson.model.AbstractBuild"/>
-          <Class name="hudson.model.AbstractBuild$AbstractBuildExecution"/>
-          <Class name="hudson.model.AbstractProject"/>
-          <Class name="hudson.model.Actionable"/>
-          <Class name="hudson.model.AutoCompletionCandidates"/>
-          <Class name="hudson.model.Cause$UpstreamCause"/>
-          <Class name="hudson.model.ChoiceParameterDefinition"/>
-          <Class name="hudson.model.Computer$DisplayExecutor"/>
-          <Class name="hudson.model.ComputerPanelBox"/>
-          <Class name="hudson.model.DependencyGraph"/>
-          <Class name="hudson.model.DependencyGraph$Dependency"/>
-          <Class name="hudson.model.Executor"/>
-          <Class name="hudson.model.FileParameterValue"/>
-          <Class name="hudson.model.Fingerprint"/>
-          <Class name="hudson.model.FullDuplexHttpChannel"/>
-          <Class name="hudson.model.Hudson"/>
-          <Class name="hudson.model.Label"/>
-          <Class name="hudson.model.labels.LabelAtom"/>
-          <Class name="hudson.model.labels.LabelExpressionLexer"/>
-          <Class name="hudson.model.ListView"/>
-          <Class name="hudson.model.MyViewsProperty"/>
-          <Class name="hudson.model.ParametersDefinitionProperty"/>
-          <Class name="hudson.model.Project"/>
-          <Class name="hudson.model.Queue$Item"/>
-          <Class name="hudson.model.queue.FutureImpl"/>
-          <Class name="hudson.model.queue.ScheduleResult$Created"/>
-          <Class name="hudson.model.queue.ScheduleResult$Existing"/>
-          <Class name="hudson.model.queue.WorkUnit"/>
-          <Class name="hudson.model.Run"/>
-          <Class name="hudson.model.Run$ArtifactList"/>
-          <Class name="hudson.model.Run$RunExecution"/>
-          <Class name="hudson.model.Slave"/>
-          <Class name="hudson.model.TaskAction"/>
-          <Class name="hudson.model.TimeSeries"/>
-          <Class name="hudson.model.UpdateCenter"/>
-          <Class name="hudson.model.UpdateCenter$DownloadJob"/>
-          <Class name="hudson.model.UpdateCenter$UpdateCenterJob"/>
-          <Class name="hudson.model.UpdateSite$Data"/>
-          <Class name="hudson.model.UpdateSite$Plugin"/>
-          <Class name="hudson.model.View"/>
-          <Class name="hudson.model.View$UserInfo"/>
-          <Class name="hudson.Plugin"/>
-          <Class name="hudson.PluginFirstClassLoader"/>
-          <Class name="hudson.PluginManager"/>
-          <Class name="hudson.PluginManager$PluginCycleDependenciesMonitor"/>
-          <Class name="hudson.PluginWrapper"/>
-          <Class name="hudson.PluginWrapper$PluginDisableResult"/>
-          <Class name="hudson.Proc$LocalProc"/>
-          <Class name="hudson.scheduler.CrontabLexer"/>
-          <Class name="hudson.scm.AbstractScmTagAction"/>
-          <Class name="hudson.scm.ChangeLogSet"/>
-          <Class name="hudson.security.ACLContext"/>
-          <Class name="hudson.security.ContainerAuthentication"/>
-          <Class name="hudson.security.LegacyAuthorizationStrategy"/>
-          <Class name="hudson.slaves.Cloud$CloudState"/>
-          <Class name="hudson.slaves.EnvironmentVariablesNodeProperty"/>
-          <Class name="hudson.slaves.NodeProvisioner$StrategyState"/>
-          <Class name="hudson.slaves.SlaveComputer"/>
-          <Class name="hudson.tasks.Fingerprinter$FingerprintAction"/>
-          <Class name="hudson.tasks.Maven$DescriptorImpl"/>
-          <Class name="hudson.tools.ToolInstallation"/>
-          <Class name="hudson.tools.ToolLocationNodeProperty$ToolLocation"/>
-          <Class name="hudson.triggers.SCMTrigger$BuildAction"/>
-          <Class name="hudson.triggers.SCMTrigger$SCMTriggerCause"/>
-          <Class name="hudson.util.ArgumentListBuilder"/>
-          <Class name="hudson.util.ByteArrayOutputStream2"/>
-          <Class name="hudson.util.ChartUtil$NumberOnlyBuildLabel"/>
-          <Class name="hudson.util.CyclicGraphDetector"/>
-          <Class name="hudson.util.JVMBuilder"/>
-          <Class name="hudson.util.PackedMap"/>
-          <Class name="hudson.util.RunList"/>
-          <Class name="hudson.util.StreamTaskListener"/>
-          <Class name="hudson.XmlFile"/>
-          <Class name="jenkins.diagnosis.HsErrPidList"/>
-          <Class name="jenkins.fingerprints.GlobalFingerprintConfiguration"/>
-          <Class name="jenkins.management.AdministrativeMonitorsApiData"/>
-          <Class name="jenkins.MissingDependencyException"/>
-          <Class name="jenkins.model.ArtifactManagerConfiguration"/>
-          <Class name="jenkins.model.FingerprintFacet"/>
-          <Class name="jenkins.model.GlobalBuildDiscarderConfiguration"/>
-          <Class name="jenkins.model.item_category.Categories"/>
-          <Class name="jenkins.model.item_category.Category"/>
-          <Class name="jenkins.model.Jenkins"/>
-          <Class name="jenkins.model.lazy.AbstractLazyLoadRunMap"/>
-          <Class name="jenkins.model.lazy.LazyBuildMixIn"/>
-          <Class name="jenkins.model.lazy.LazyBuildMixIn$RunMixIn"/>
-          <Class name="jenkins.model.queue.AsynchronousExecution"/>
-          <Class name="jenkins.security.apitoken.ApiTokenStats$SingleTokenStats"/>
-          <Class name="jenkins.security.apitoken.ApiTokenStore$HashedToken"/>
-          <Class name="jenkins.security.ApiTokenProperty"/>
-          <Class name="jenkins.security.NonSerializableSecurityContext"/>
-          <Class name="jenkins.security.QueueItemAuthenticatorConfiguration"/>
-          <Class name="jenkins.slaves.IOHubProvider"/>
-          <Class name="jenkins.slaves.NioChannelSelector"/>
-          <Class name="jenkins.tasks.filters.EnvVarsFilterRuleContext"/>
-          <Class name="jenkins.tasks.SimpleBuildWrapper$Context"/>
-          <Class name="jenkins.util.AtmostOneTaskExecutor"/>
-          <Class name="jenkins.util.groovy.GroovyHookScript"/>
-          <Class name="jenkins.util.io.CompositeIOException"/>
-          <Class name="jenkins.util.xstream.XStreamDOM"/>
-          <Class name="org.acegisecurity.AuthenticationException"/>
-          <Class name="org.acegisecurity.context.SecurityContextImpl"/>
-          <Class name="org.acegisecurity.providers.AbstractAuthenticationToken"/>
-          <Class name="org.acegisecurity.providers.anonymous.AnonymousAuthenticationToken"/>
-          <Class name="org.acegisecurity.providers.UsernamePasswordAuthenticationToken"/>
-          <Class name="org.acegisecurity.userdetails.User"/>
-          <Class name="org.jenkins.ui.icon.IconSet"/>
-        </Or>
-      </And>
-      <And>
-        <Bug pattern="EI_EXPOSE_REP2"/>
-        <Or>
-          <Class name="hudson.cli.CLICommand"/>
-          <Class name="hudson.console.ConsoleAnnotationOutputStream"/>
-          <Class name="hudson.FilePath$ExplicitlySpecifiedDirScanner"/>
-          <Class name="hudson.Functions$RunUrl"/>
-          <Class name="hudson.Launcher$DecoratedLauncher"/>
-          <Class name="hudson.Launcher$ProcStarter"/>
-          <Class name="hudson.logging.LogRecorder"/>
-          <Class name="hudson.logging.LogRecorderManager"/>
-          <Class name="hudson.logging.WeakLogHandler"/>
-          <Class name="hudson.MarkupText$SubText"/>
-          <Class name="hudson.model.AbstractBuild$AbstractBuildExecution"/>
-          <Class name="hudson.model.AbstractBuild$AbstractRunner"/>
-          <Class name="hudson.model.AllView"/>
-          <Class name="hudson.model.Computer$DisplayExecutor"/>
-          <Class name="hudson.model.ComputerPanelBox"/>
-          <Class name="hudson.model.DependencyGraph$Dependency"/>
-          <Class name="hudson.model.EnvironmentList"/>
-          <Class name="hudson.model.Executor"/>
-          <Class name="hudson.model.ListView"/>
-          <Class name="hudson.model.MyView"/>
-          <Class name="hudson.model.ParametersAction"/>
-          <Class name="hudson.model.queue.WorkUnit"/>
-          <Class name="hudson.model.queue.WorkUnitContext"/>
-          <Class name="hudson.model.Run$ArtifactList"/>
-          <Class name="hudson.model.Run$KeepLogBuildBadge"/>
-          <Class name="hudson.model.Run$RunExecution"/>
-          <Class name="hudson.model.TaskThread$ListenerAndText"/>
-          <Class name="hudson.model.UpdateCenter$CompleteBatchJob"/>
-          <Class name="hudson.model.UpdateCenter$CompleteBatchJob$CompleteBatchJobStatus"/>
-          <Class name="hudson.model.UpdateCenter$CompleteBatchJob$Pending"/>
-          <Class name="hudson.model.UpdateCenter$CompleteBatchJob$Running"/>
-          <Class name="hudson.model.UpdateCenter$CompleteBatchJob$Success"/>
-          <Class name="hudson.model.UpdateCenter$ConnectionCheckJob"/>
-          <Class name="hudson.model.UpdateCenter$DownloadJob$Failure"/>
-          <Class name="hudson.model.UpdateCenter$DownloadJob$InstallationStatus"/>
-          <Class name="hudson.model.UpdateCenter$DownloadJob$Installing"/>
-          <Class name="hudson.model.UpdateCenter$DownloadJob$Pending"/>
-          <Class name="hudson.model.UpdateCenter$DownloadJob$Skipped"/>
-          <Class name="hudson.model.UpdateCenter$DownloadJob$Success"/>
-          <Class name="hudson.model.UpdateCenter$DownloadJob$SuccessButRequiresRestart"/>
-          <Class name="hudson.model.UpdateCenter$EnableJob"/>
-          <Class name="hudson.model.UpdateCenter$HudsonDowngradeJob"/>
-          <Class name="hudson.model.UpdateCenter$HudsonUpgradeJob"/>
-          <Class name="hudson.model.UpdateCenter$InstallationJob"/>
-          <Class name="hudson.model.UpdateCenter$NoOpJob"/>
-          <Class name="hudson.model.UpdateCenter$PluginDowngradeJob"/>
-          <Class name="hudson.model.UpdateCenter$RestartJenkinsJob"/>
-          <Class name="hudson.model.UpdateCenter$RestartJenkinsJob$Canceled"/>
-          <Class name="hudson.model.UpdateCenter$RestartJenkinsJob$Failure"/>
-          <Class name="hudson.model.UpdateCenter$RestartJenkinsJob$Pending"/>
-          <Class name="hudson.model.UpdateCenter$RestartJenkinsJob$RestartJenkinsJobStatus"/>
-          <Class name="hudson.model.UpdateCenter$RestartJenkinsJob$Running"/>
-          <Class name="hudson.model.UpdateSite$Plugin"/>
-          <Class name="hudson.PluginManager$UberClassLoader"/>
-          <Class name="hudson.PluginWrapper"/>
-          <Class name="hudson.scm.AbstractScmTagAction"/>
-          <Class name="hudson.search.FixedSet"/>
-          <Class name="hudson.slaves.Cloud$CloudState"/>
-          <Class name="hudson.slaves.NodeProvisioner"/>
-          <Class name="hudson.slaves.SlaveComputer"/>
-          <Class name="hudson.tasks.BatchFile"/>
-          <Class name="hudson.tasks.BuildWrapper$Environment"/>
-          <Class name="hudson.tasks.Fingerprinter$FingerprintAction"/>
-          <Class name="hudson.tasks.Shell"/>
-          <Class name="hudson.TcpSlaveAgentListener$TcpSlaveAgentListenerRescheduler"/>
-          <Class name="hudson.tools.ToolLocationNodeProperty$ToolLocation"/>
-          <Class name="hudson.triggers.SCMTrigger$BuildAction"/>
-          <Class name="hudson.triggers.SCMTrigger$Runner"/>
-          <Class name="hudson.triggers.SCMTrigger$SCMAction"/>
-          <Class name="hudson.triggers.SCMTrigger$SCMTriggerCause"/>
-          <Class name="hudson.triggers.Trigger"/>
-          <Class name="hudson.util.ChartUtil$NumberOnlyBuildLabel"/>
-          <Class name="hudson.util.ChunkedOutputStream"/>
-          <Class name="hudson.util.DualOutputStream"/>
-          <Class name="hudson.util.ForkOutputStream"/>
-          <Class name="hudson.util.FormValidation$CheckMethod"/>
-          <Class name="hudson.util.JVMBuilder"/>
-          <Class name="hudson.util.ReflectionUtils$Parameter"/>
-          <Class name="hudson.util.StreamCopyThread"/>
-          <Class name="hudson.util.TagCloud$Entry"/>
-          <Class name="hudson.util.VariableResolver$ByMap"/>
-          <Class name="hudson.util.WriterOutputStream"/>
-          <Class name="hudson.XmlFile"/>
-          <Class name="jenkins.fingerprints.GlobalFingerprintConfiguration"/>
-          <Class name="jenkins.MissingDependencyException"/>
-          <Class name="jenkins.model.BlockedBecauseOfBuildInProgress"/>
-          <Class name="jenkins.model.FingerprintFacet"/>
-          <Class name="jenkins.model.item_category.Category"/>
-          <Class name="jenkins.model.Jenkins"/>
-          <Class name="jenkins.model.queue.AsynchronousExecution"/>
-          <Class name="jenkins.model.StandardArtifactManager"/>
-          <Class name="jenkins.org.apache.commons.validator.routines.DomainValidator$Item"/>
-          <Class name="jenkins.security.ImpersonatingExecutorService"/>
-          <Class name="jenkins.security.ImpersonatingScheduledExecutorService"/>
-          <Class name="jenkins.security.NonSerializableSecurityContext"/>
-          <Class name="jenkins.slaves.EncryptedSlaveAgentJnlpFile"/>
-          <Class name="jenkins.tasks.filters.EnvVarsFilterRuleContext"/>
-          <Class name="jenkins.tasks.filters.EnvVarsFilterRuleWrapper"/>
-          <Class name="jenkins.util.groovy.GroovyHookScript"/>
-          <Class name="jenkins.util.io.CompositeIOException"/>
-          <Class name="jenkins.util.xml.FilteredFunctionContext"/>
-          <Class name="jenkins.util.xstream.XStreamDOM"/>
-          <Class name="org.acegisecurity.AuthenticationException"/>
-          <Class name="org.acegisecurity.context.SecurityContextImpl"/>
-          <Class name="org.acegisecurity.providers.anonymous.AnonymousAuthenticationToken"/>
-          <Class name="org.acegisecurity.providers.UsernamePasswordAuthenticationToken"/>
-        </Or>
-      </And>
       <And>
         <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS"/>
         <Or>
@@ -362,19 +132,6 @@
           <Class name="hudson.triggers.Trigger"/>
         </Or>
       </And>
-      <And>
-        <Bug pattern="MS_EXPOSE_REP"/>
-        <Or>
-          <Class name="hudson.model.ComputerSet"/>
-          <Class name="hudson.model.Fingerprint"/>
-          <Class name="hudson.model.PaneStatusProperties"/>
-          <Class name="hudson.os.PosixAPI"/>
-          <Class name="hudson.security.Permission"/>
-          <Class name="hudson.util.FormValidation"/>
-          <Class name="hudson.util.ProcessTree"/>
-          <Class name="jenkins.tasks.filters.EnvVarsFilterGlobalConfiguration"/>
-        </Or>
-      </And>
       <And>
         <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>
         <Or>

@basil basil requested a review from timja November 2, 2022 22:25
@basil basil merged commit 2628e92 into jenkinsci:master Nov 2, 2022
@basil basil deleted the FindReturnRef branch November 2, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants