Use javax.annotation-api from core #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 22, 2021
MarkEWaite
approved these changes
Dec 22, 2021
uhafner
reviewed
Dec 23, 2021
uhafner
requested changes
Dec 23, 2021
Done |
uhafner
approved these changes
Dec 23, 2021
jglick
added a commit
to jenkinsci/mock-load-builder-plugin
that referenced
this pull request
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in jenkinsci/nodelabelparameter-plugin#76. The explicit dependency on javax.annotation-api causes Enforcer errors for other plugins with this plugin in their dependency chain (typically through matrix-project or junit) and is unnecessary because the plugin parent POM already adds a dependency on core which ships this library anyway.