Update deps #138
Merged
Update deps #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
commented
Dec 28, 2021
Comment on lines
-160
to
-162
| <build> | ||
| <defaultGoal>clean hpi:run</defaultGoal> | ||
| </build> |
There was a problem hiding this comment.
Nonstandard. Introduced in #44.
jglick
commented
Dec 28, 2021
pom.xml
Outdated
| @@ -54,18 +54,15 @@ | |||
| <groupId>org.hamcrest</groupId> | |||
| <artifactId>hamcrest-core</artifactId> | |||
| </exclusion> | |||
| <exclusion> <!-- TODO unwanted dep via plugin-util-api --> | |||
There was a problem hiding this comment.
Closed
basil
approved these changes
Dec 28, 2021
This was referenced Jan 3, 2022
|
In case it is not obvious, a release of this would be highly appreciated to resolve Enforcer errors in dependent plugins. |
|
Care to approve #141? I seem to be a “maintainer”. |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via jenkinsci/mock-load-builder-plugin#20 I found that this plugin was not yet adapted to jenkinsci/jenkins#4660.
Unlike jenkinsci/jackson2-api-plugin#96 we were not bundling the old JavaMail lib, we were just compiling against it.