Fix wrong usage of CauseAction, rename some method.

[tianzhipeng-git]

SInce hudson.model.Run

 public @Nonnull List getCauses() {
        CauseAction a = getAction(CauseAction.class);
        if (a==null)    return Collections.emptyList();
        return Collections.unmodifiableList(a.getCauses());
   }

use just one CauseAction object to get several causes, So adding several CauseAction doesn't work.

[GLundh]

Please avoid System.out. Use logging if text output necessary (but it is?)

[tianzhipeng-git]

It's my debugging output. Been removed.

[franknarf8]

This should fix the unit tests :

diff --git a/src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java b/src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java
index 58d51db..730691a 100644
--- a/src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java
+++ b/src/test/java/com/sonyericsson/rebuild/RebuildValidatorTest.java
@@ -47,7 +47,6 @@ import org.jvnet.hudson.test.TestExtension;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 import java.io.IOException;
-import java.util.List;
 import java.util.concurrent.ExecutionException;
 
 /**
@@ -253,25 +252,23 @@ public class RebuildValidatorTest extends HudsonTestCase {
 		while (project.isBuilding()) {
 			Thread.sleep(DELAY);
 		}
-		List<Action> actions = project.getLastCompletedBuild().getActions();
 		boolean hasRebuildCause = false;
 		boolean hasRemoteCause = false;
 		boolean hasUserIdCause = false;
-		for (Action action : actions) {
+		for (Action action : project.getLastCompletedBuild().getAllActions()) {
 			if (action instanceof CauseAction) {
-				CauseAction causeAction = (CauseAction) action;
-				if (causeAction.getCauses().get(0).getClass()
-						.equals(RebuildCause.class)) {
-					hasRebuildCause = true;
-				}
-				if (causeAction.getCauses().get(0).getClass()
-						.equals(Cause.RemoteCause.class)) {
-					hasRemoteCause = true;
-				}
-				if (causeAction.getCauses().get(0).getClass()
-						.equals(Cause.UserIdCause.class)) {
-					hasUserIdCause = true;
+				for(Cause cause : ((CauseAction)action).getCauses()) {
+					if (cause.getClass().equals(RebuildCause.class)) {
+						hasRebuildCause = true;
+					}
+					if (cause.getClass().equals(Cause.RemoteCause.class)) {
+						hasRemoteCause = true;
+					}
+					if (cause.getClass().equals(Cause.UserIdCause.class)) {
+						hasUserIdCause = true;
+					}
 				}
+
 			}
 		}
 		assertTrue("Build should have user, remote and rebuild causes",

[franknarf8]

@tianzhipeng-git @GLundh ,

Should I fork @tianzhipeng-git 's fork and open another pull request?

Thanks