Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong usage of CauseAction, rename some method + Fix unit test #56

Merged
merged 3 commits into from
Mar 20, 2019
Merged

Fix wrong usage of CauseAction, rename some method + Fix unit test #56

merged 3 commits into from
Mar 20, 2019

Conversation

franknarf8
Copy link

Contains the fix of the following pull request : #54
And a fix for the broken unit test

tzp and others added 3 commits August 23, 2018 21:56
…hCauseThenCauseIsCopiedAndUserCauseAdded

- We are now validating that the different build causes are contained within the CauseAction instance
@franknarf8
Copy link
Author

@tianzhipeng-git @GLundh

@GLundh GLundh merged commit 3111eba into jenkinsci:master Mar 20, 2019
@franknarf8
Copy link
Author

@GLundh Thanks a lot!

Could we do a new release of this repo?

Thanks in advance!

@GLundh
Copy link
Member

GLundh commented Mar 20, 2019

I'll try to get a new release out this weekend.

@kapoorlakshya
Copy link

Hi @franknarf8 @GLundh - I think I've found a bug introduced by this change in the v1.30 release. Here's what's happening:

In v1.29:
When user B rebuilds user A's job, the $BUILD_USER is updated to user B.

In v1.30:
Now when user B rebuilds user A's job, the $BUILD_USER is still A.

I am on Jenkins v2.164.1 and I am reading the build user using the Build User Vars plugin. Please let me know if I can provide any other information to troubleshoot this. Thank you!

@marble-ma
Copy link

saw same issue as @kapoorlakshya

@kapoorlakshya
Copy link

Another change I noticed in v1.30 is this:

image

It lists the rebuild history (parent, grandparent build, and so on) instead of just the "parent" one. From v1.29 for comparison:

image

@eryajf
Copy link

eryajf commented Apr 26, 2019

您好@ franknarf8 @GLundh - 我想我发现v1.30版本中此更改引入了一个错误。这是发生了什么:

在v1.29中:
当用户B重建用户A的作业时,$ BUILD_USER将更新为用户B.

在v1.30中:
现在当用户B重建用户A的作业时,$ BUILD_USER仍为A.

我在Jenkins v2.164.1上,我正在使用Build User Vars插件阅读构建用户。如果我能提供任何其他信息来解决此问题,请告知我们。谢谢!

I also encountered the same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants