Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression notification implemented. #294

Merged
merged 1 commit into from
Mar 11, 2017

Conversation

prashantkalkar
Copy link
Contributor

@prashantkalkar prashantkalkar commented Mar 3, 2017

Notification generated for following cases:

  • If number of failed tests increased. (Even when previous build was red).
  • If the failed tests are different than previous build (Even when the number of failed tests are same as last build).

Will not notify for

  • For failure that are same as previous build.

In short, will notify if the current build is worst than the previous build.

@samrocketman
Copy link
Member

@prashant-ee can you rebase instead of merge?

Copy link
Member

@samrocketman samrocketman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been thoroughly tested with Slack and Mattermost using https://github.com/samrocketman/jenkins-bootstrap-slack.

  • ✅ The plugin smoothly upgrades without breaking existing configurations.
  • ✅ The code integrates well with existing configurations.
  • ✅ You have included tests!

Thanks for your contribution. This will be merged pending a CI validation of your rebased commit.

@samrocketman samrocketman merged commit 9c57909 into jenkinsci:master Mar 11, 2017
samrocketman added a commit that referenced this pull request Mar 11, 2017
@samrocketman samrocketman mentioned this pull request Mar 11, 2017
@prashantkalkar
Copy link
Contributor Author

Thanks for accepting the changes​. Happy to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants