Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce verbosity for standard case #395

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Conversation

Vlatombe
Copy link
Member

On every startup I'm getting log lines whereas the migrator does nothing
(because there is nothing to migrate)

On every startup I'm getting log lines whereas the migrator does nothing
(because there is nothing to migrate)
@AnneTheAgile
Copy link

AnneTheAgile commented Sep 16, 2018

+1 This is very important.
I see it is up for adoption :( so then how does a PR get added?

This PR is great since it makes logger.finest for entry of the method, and it is already logger.finest when: "Configuration is already up to date for "%s", skipping migration"

Apparently the migrator migrates "from the 1.8 format to the 2.0 format. It does so by removing the SlackJobProperty from the job properties (if there is one)."
However, now being on v2.2 since 8a4fa61 on Mar 11, 2017 CHANGELOG for #294 , we should not be needing this.

Sep 16, 2018 12:23:55 PM jenkins.plugins.slack.config.AbstractProjectConfigMigrator migrate
INFO: Migrating project "_myjob" with type hudson.model.FreeStyleProject

^^ example of a log message, and there is one line for each job, including multi branch repos, one per branch.

Copy link

@AnneTheAgile AnneTheAgile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AnneTheAgile
Copy link

AnneTheAgile commented Sep 16, 2018

Not sure if it worked to LGTM but gave it a go!
//got ok; Your review was submitted successfully.

@AnneTheAgile
Copy link

per #320 new maintainers are @kmadel and @gurumaia I hope they will be able to take a look.

@kmadel kmadel merged commit 1d943d3 into jenkinsci:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants