[JENKINS-59342] Builds / Nodes / Items bundles

[Dohbedoh]

JENKINS-59342: Provide the ability for Administrators to download contents for Builds, Items and Nodes. Details in the JIRA.

@MRamonLeon @aheritier @Evildethow @varyvol

[Dohbedoh]

Still need to check on those failing tests in windows.

[varyvol]

One question: what happens when the content to be zipped and downloaded is big? Are there issues creating the ZIP? Or downloading it?

[varyvol]

Why did you need this now?

[Dohbedoh]

To be able to have component that can be used at root level, and also at another level (Computer, Build, Item, ....). This method is used to list the components that can be used by from an Action. For example, we have a component DumpExportTable that get the exports table of all nodes when used from the root action. We can use the same component from the Node action to get the content only for the node.
Maybe there is a better design for this. I am open to suggestions.

[Dohbedoh]

One question: what happens when the content to be zipped and downloaded is big? Are there issues creating the ZIP? Or downloading it?

@varyvol This is going through the same method than the root Support Bundle generation. Subjected to the same technical vulnerabilities.

[varyvol]

@Dohbedoh but the same technical limitations might work for a situation and not for others. For example, imagine a limitation is the bundle has a maximum capacity of 10mb that is very rarely reached with the usual bundle but will always be reached through this use case. That would make this use case unusable in the practice.

The code itself looks good, but there are test failures. Could you review them?

[Dohbedoh]

a limitation is the bundle has a maximum capacity of 10mb that is very rarely reached with the usual bundle but will always be reached through this use case.

I believe that if we were applying such kind of limitation, we could also add configurability to it, depending on what the scenario.

---

I will check on this. Tests are failing on Windows. I have tested the plugin in a instance running on windows and confirmed that it works. I haven't run the tests in a windows environment though...

[Dohbedoh]

I did find out that the ZIP entries in the case of windows have a mix of path separators, for example items/testFolder/jobs/testFreestyle/builds\1\build.xml. We should make sure that ZipEntry uses only forward slash.