Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPE in AgentsConfigFile.addContents #611

Merged
merged 1 commit into from
Jan 20, 2025
Merged

NPE in AgentsConfigFile.addContents #611

merged 1 commit into from
Jan 20, 2025

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 13, 2025

Apparently a regression in #198:

WARNING	c.c.j.support.SupportPlugin#appendManifestContents: Could not get content from Agent Configuration File for support bundle
java.lang.NullPointerException
	at java.base/java.util.Objects.requireNonNull(Objects.java:233)
	at PluginClassLoader for support-core//com.cloudbees.jenkins.support.configfiles.AgentsConfigFile.lambda$addContents$0(AgentsConfigFile.java:87)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at PluginClassLoader for support-core//com.cloudbees.jenkins.support.configfiles.AgentsConfigFile.addContents(AgentsConfigFile.java:87)
	at PluginClassLoader for support-core//com.cloudbees.jenkins.support.SupportPlugin$1.visit(SupportPlugin.java:358)
	at PluginClassLoader for support-core//com.cloudbees.jenkins.support.SupportPlugin.appendManifestContents(SupportPlugin.java:608)
	at PluginClassLoader for support-core//com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:389)
	at PluginClassLoader for support-core//com.cloudbees.jenkins.support.SupportPlugin.writeBundle(SupportPlugin.java:355)
	at PluginClassLoader for support-core//com.cloudbees.jenkins.support.SupportPlugin$PeriodicWorkImpl.lambda$doRun$0(SupportPlugin.java:986)

Observed in a heavily loaded controller.

@jglick jglick added the bug label Jan 13, 2025
@jglick jglick requested a review from a team as a code owner January 13, 2025 22:41
@jglick jglick requested a review from Dohbedoh January 14, 2025 21:20
@Dohbedoh Dohbedoh added this pull request to the merge queue Jan 20, 2025
Merged via the queue into jenkinsci:master with commit 77f9dac Jan 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dohbedoh Dohbedoh Dohbedoh approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jglick @Dohbedoh