[JENKINS-40161] Handle exceptions from StepExecution.onResume
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
car-roll
approved these changes
Dec 15, 2021
dwnusbaum
reviewed
Dec 15, 2021
src/main/java/org/jenkinsci/plugins/workflow/flow/FlowExecutionList.java
Show resolved
Hide resolved
dwnusbaum
approved these changes
Dec 15, 2021
dwnusbaum
added a commit
to dwnusbaum/workflow-api-plugin
that referenced
this pull request
Jan 14, 2022
…e` (jenkinsci#187)" This reverts commit 6a04bac.
6 tasks
dwnusbaum
reviewed
Sep 25, 2023
| try { | ||
| se.onResume(); | ||
| } catch (Throwable x) { | ||
| se.getContext().onFailure(x); |
There was a problem hiding this comment.
Looking at this again, it might be better to use se.stop instead, although I'm not sure that it matters for any existing steps besides node. Compare to semi-related changes in jenkinsci/workflow-cps-plugin#780 and jenkinsci/workflow-durable-task-step-plugin#344.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for https://issues.jenkins.io/browse/JENKINS-40161. Cannot safely add
throws Exceptionto the method signature, or start letting implementations throw exceptions, until most users have updated to get this code, so might as well do it now rather than later; at least will already handleRuntimeExceptionandError.Not really related to #178, which just moved this block of code around without changing what it did when called.