Add new symbol related API functions. #2741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rerobika
added
api
zherczeg
requested changes
Jan 31, 2019
Member
Author
|
@zherczeg Thanks for the review, I've applied your suggestions. |
LaszloLango
requested changes
Feb 1, 2019
galpeter
reviewed
Feb 6, 2019
Member
Author
|
@LaszloLango @galpeter Thanks for the reviews, I've updated the PR. |
Member
Author
|
@galpeter Do you have any other thoughts/comments on this PR? |
galpeter
reviewed
Feb 8, 2019
rerobika
force-pushed
the
symbol_api
branch
3 times, most recently
from
9f8b885 to
37b1b09
Compare
galpeter
reviewed
Feb 13, 2019
New functions: - ecma_create_symbol - ecma_value_is_symbol - jerry_get_symbol_descriptive_string Also improve the jerryx_handler_print to be able to print symbol values via using the jerry_get_symbol_descriptive_string API function for symbol values. JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Mar 26, 2019
Picked from upstream jerryscript-project/jerryscript/pull/2741
3 tasks
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Mar 28, 2019
* jerry: Add new symbol related API functions. Picked from upstream jerryscript-project/jerryscript/pull/2741 * n-api: add napi_create_symbol * jerry: Ensure that symbol properties can be set via computed object literals Picked from upstream jerryscript-project/jerryscript/pull/2747 * Revert jerry_value_is_error/jerry_get_value_from_error to jerry_value_has_error_flag/jerry_get_value_without_error_flag * jerry: Fixes assertion on calling String builtin with symbol Picked from upstream jerryscript-project/jerryscript/pull/2803
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Mar 28, 2019
* jerry: Add new symbol related API functions. Picked from upstream jerryscript-project/jerryscript/pull/2741 * n-api: add napi_create_symbol * jerry: Ensure that symbol properties can be set via computed object literals Picked from upstream jerryscript-project/jerryscript/pull/2747 * Revert jerry_value_is_error/jerry_get_value_from_error to jerry_value_has_error_flag/jerry_get_value_without_error_flag * jerry: Fixes assertion on calling String builtin with symbol Picked from upstream jerryscript-project/jerryscript/pull/2803
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Mar 29, 2019
* jerry: Add new symbol related API functions. Picked from upstream jerryscript-project/jerryscript/pull/2741 * n-api: add napi_create_symbol * jerry: Ensure that symbol properties can be set via computed object literals Picked from upstream jerryscript-project/jerryscript/pull/2747 * Revert jerry_value_is_error/jerry_get_value_from_error to jerry_value_has_error_flag/jerry_get_value_without_error_flag * jerry: Fixes assertion on calling String builtin with symbol Picked from upstream jerryscript-project/jerryscript/pull/2803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New functions:
Also improve the
jerryx_handler_printto be able to print symbol values via using theecma_get_symbol_descriptive_stringAPI function for symbol values.JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu