Ensure that symbol properties can be set via computed object literals #2747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu
rerobika
added
development
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Mar 26, 2019
…iterals picked from upstream jerryscript-project/jerryscript/pull/2747
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Mar 28, 2019
* jerry: Add new symbol related API functions. Picked from upstream jerryscript-project/jerryscript/pull/2741 * n-api: add napi_create_symbol * jerry: Ensure that symbol properties can be set via computed object literals Picked from upstream jerryscript-project/jerryscript/pull/2747 * Revert jerry_value_is_error/jerry_get_value_from_error to jerry_value_has_error_flag/jerry_get_value_without_error_flag * jerry: Fixes assertion on calling String builtin with symbol Picked from upstream jerryscript-project/jerryscript/pull/2803
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Mar 28, 2019
* jerry: Add new symbol related API functions. Picked from upstream jerryscript-project/jerryscript/pull/2741 * n-api: add napi_create_symbol * jerry: Ensure that symbol properties can be set via computed object literals Picked from upstream jerryscript-project/jerryscript/pull/2747 * Revert jerry_value_is_error/jerry_get_value_from_error to jerry_value_has_error_flag/jerry_get_value_without_error_flag * jerry: Fixes assertion on calling String builtin with symbol Picked from upstream jerryscript-project/jerryscript/pull/2803
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Mar 29, 2019
* jerry: Add new symbol related API functions. Picked from upstream jerryscript-project/jerryscript/pull/2741 * n-api: add napi_create_symbol * jerry: Ensure that symbol properties can be set via computed object literals Picked from upstream jerryscript-project/jerryscript/pull/2747 * Revert jerry_value_is_error/jerry_get_value_from_error to jerry_value_has_error_flag/jerry_get_value_without_error_flag * jerry: Fixes assertion on calling String builtin with symbol Picked from upstream jerryscript-project/jerryscript/pull/2803
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Robert Fancsik frobert@inf.u-szeged.hu